New issue
Advanced search Search tips

Issue 638468 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 609258
issue 629181



Sign in to add a comment

Ignore WebApplicationInfo when creating WebAPK

Project Member Reported by pkotw...@chromium.org, Aug 17 2016

Issue description

Ignore WebApplicationInfo when creating WebAPK
 
Can you elaborate on this bug?
add_to_homescreen_data_fetcher.cc checks if <meta> tags like
<meta name='application-name' content='Rey Bango Front-end Developer'>
have been specified to get web app properties.

Currently, it is possible for a WebAPK to be generated if the web page has <meta name='application-name'> but the Web Manifest does not have either a name or a short_name.
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9

commit 0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed Sep 28 15:56:46 2016

Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG= 638468 

Review-Url: https://codereview.chromium.org/2362813003
Cr-Commit-Position: refs/heads/master@{#421531}

[modify] https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Status: Fixed (was: Assigned)
The bug reported was imaginary (it did not exist). The CL in comment #4 makes it clearer that this bug does not exist.

Marking as fixed
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a320b1c806c52f388c68ebe69864d2f211d688f8

commit a320b1c806c52f388c68ebe69864d2f211d688f8
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 30 19:08:20 2016

Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ )

Reason for revert:
"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel

Original issue's description:
> Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
>
> This CL:
> - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
>   is ignored for WebAPK compatible pages.
> - Adds tests checking that WebApplicationInfo is ignored
>
> BUG= 638468 
>
> Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
> Cr-Commit-Position: refs/heads/master@{#421531}

TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 638468 ,  651289 

Review-Url: https://codereview.chromium.org/2385843002
Cr-Commit-Position: refs/heads/master@{#422170}

[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Status: Assigned (was: Fixed)
Labels: -Pri-3 Pri-1
Blocking: 629181
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e

commit f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed Dec 21 04:17:50 2016

Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG= 638468 

Review-Url: https://codereview.chromium.org/2387613003
Cr-Commit-Position: refs/heads/master@{#440013}

[modify] https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment