[People] Account information and sync in the wrong places |
|||||
Issue descriptionActual: The email address is attached to the sync row Alan ---- Sync Signed in as janedoe@gmail.com ---- Expected: The email address should be attached to the profile name and Sync's description text should be a status of the user's current sync settings, such as "On - sync everything" Alan janedoe@gmail.com ---- Sync On - sync everything ---- For a list of sync status messages, see the mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-People-account.png%3Fz=width
,
Sep 14 2016
,
Oct 3 2016
,
Oct 4 2016
,
Oct 4 2016
ewald@, just to make sure, there are in total 5 sync status messages with email addressed attached to them, do they all need to drop the email? https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=11600,11712,11715,11718,11721
,
Oct 4 2016
Yes. There's a separate bug ( Issue 612595 , also assigned to you) about updating the status/error messages according to our new spec. But in those messages, the email address is gone.
,
Oct 6 2016
Just a heads up, the sync rows have recently been updated to have "page indicators" (right-facing arrows and open-in-new icons) communicating that a row is clickable. You can see this live in canary today. This means that the sync row(s) can have 3 types of embellishments: 1. Right-facing arrow icon - when clicking the row opens a sub-page within settings, a dialog, or any internal Chrome property (i.e. user manager). 2. Open-in-new icon - used when clicking takes you to an open web property, i.e. myaccount.google.com 3. No icon - used when the row is not actionable (passive) Please ensure that our error states use the proper embellishment. Let me know if you have any questions.
,
Oct 7 2016
Thanks Alan, what is embellishment for actionable errors?
,
Oct 7 2016
Each error has a different behavior, right? E.g. the "Passphrase" error opens the subpage/dialogue for entering your passphrase. The auth error opens the sign in flow to re-auth. I don't think any of them take you to a web property though, right? So they should probably all have the right-facing arrows, according to Alan's spec above.
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf commit 9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf Author: mahmadi <mahmadi@chromium.org> Date: Tue Oct 18 16:56:10 2016 [MD Settings][People] Updates positions of username and sync status message before: https://screenshot.googleplex.com/q9gMEb84CDy after: https://screenshot.googleplex.com/oobv4yKECg5 This CL also updates sync status messages. BUG= 638464 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2393643004 Cr-Commit-Position: refs/heads/master@{#425991} [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/app/generated_resources.grd [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/resources/options/browser_options.js [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/resources/options/sync_section.html [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/resources/settings/people_page/sync_browser_proxy.js [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/signin/signin_ui_util.cc [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/signin/signin_ui_util.h [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/sync/profile_sync_service_android.cc [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/9d08a7d8a72909a0c5bfe0ed5cb0b590876b7dcf/chrome/browser/ui/webui/settings/people_handler.cc
,
Oct 19 2016
Looks great. Thank you so much!
,
Oct 19 2016
Moe - can we mark this as Fixed? We're tracking the error messages separately, right? Or is that also part of this bug.
,
Oct 19 2016
FYI looks like error messages are being tracked in Issue 612595
,
Oct 19 2016
yep. let's mark this as fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bettes@chromium.org
, Aug 17 201676.7 KB
76.7 KB View Download