Sub-headers are found on the following subpages and aren't styling consistently: customize fonts manage search engines autofill passwords languages displays (cros) manage spell check (cros) manage input methods (cros) Expected: font: 13px Roboto Medium color: paper grey 600 top-padding: 24px bottom-padding: 12px Specs have been updated to reflect this: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png%3Fz=width
This is all Alan's fault.
dschuyler@: any spare cycles?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a56e76de0f7e38f81f5be072f98a44516124b8bd commit a56e76de0f7e38f81f5be072f98a44516124b8bd Author: dschuyler <dschuyler@chromium.org> Date: Fri Aug 26 01:43:29 2016 [MD settings] using h2 for sub-headers consistently. This CL switches several differently styled sub-headers to all use h2 tags. This is good because it makes them all consistent and h2 is a good choice because screen readers may scan for h2 tags specifically to give the user context about what is on the screen. BUG= 638461 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2273083002 Cr-Commit-Position: refs/heads/master@{#414621} [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/search_engines_page/search_engine_entry.css [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/search_engines_page/search_engines_list.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/a56e76de0f7e38f81f5be072f98a44516124b8bd/chrome/browser/resources/settings/settings_ui/settings_ui.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c959e62fb8e897367694fcc9743a3bbc0656917 commit 7c959e62fb8e897367694fcc9743a3bbc0656917 Author: dschuyler <dschuyler@chromium.org> Date: Fri Aug 26 23:22:36 2016 [MD settings] layout sub-headers in display settings This CL is a follow-up to CL 2273083002 where the <h2> sub-labels were updated to the current mocks. The displays sub-page (chromeos only) also needed to be updated. BUG= 638461 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2283933002 Cr-Commit-Position: refs/heads/master@{#414855} [modify] https://crrev.com/7c959e62fb8e897367694fcc9743a3bbc0656917/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/7c959e62fb8e897367694fcc9743a3bbc0656917/chrome/browser/resources/settings/settings_shared_css.html
Comment 1 by tbuck...@chromium.org
, Aug 22 2016Labels: Hotlist-MD-Settings-General
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)