New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Separate PaymentRequest initialization and display.

Project Member Reported by rouslan@chromium.org, Aug 17 2016

Issue description

In order to better accommodate delays in querying payment apps, separate
initialization of PaymentRequest from displaying it. Thus a merchant
website can create a JavaScript PaymentRequest object on page load, but
call PaymentRequest.show() only when user clicks the [BUY] button on the
page. Then Chrome can begin to query the installed payment apps
before the user clicks the [BUY] button. This enables faster startup of
the PaymentRequest UI.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2525f9688bbb6fd26ff12d38a7c4ee5f31404122

commit 2525f9688bbb6fd26ff12d38a7c4ee5f31404122
Author: rouslan <rouslan@chromium.org>
Date: Tue Aug 23 23:22:23 2016

Separate PaymentRequest initialization and display.

In order to better accommodate delays in querying payment apps, separate
initialization of PaymentRequest from displaying it. Thus a merchant
website can create a JavaScript PaymentRequest object on page load, but
call PaymentRequest.show() only when user clicks the [BUY] button on the
page. With this patch, Chrome begins to query the installed payment apps
before the user clicks the [BUY] button. This enables faster startup of
the PaymentRequest UI.

BUG= 638454 

Review-Url: https://codereview.chromium.org/2250793003
Cr-Commit-Position: refs/heads/master@{#413893}

[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/2525f9688bbb6fd26ff12d38a7c4ee5f31404122/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment