Search within [section] has inconsistent UI |
|||
Issue descriptionPasswords, languages, and stored data all have different ways to show search UI. I've attached a more explicit spec to follow when presenting search ui + always include the 16px search icon + always include hint text + input text is darker then hint text + surface the close button when inputting text (which we seem to already be doing) Spec https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_search.png%3Fz=width
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e commit 6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e Author: dschuyler <dschuyler@chromium.org> Date: Fri Aug 26 01:42:46 2016 [MD settings] layout sub-page search This CL changes the layout of the search input within a sub-page to more closely match the updated mocks. BUG= 638453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2279093002 Cr-Commit-Position: refs/heads/master@{#414620} [modify] https://crrev.com/6c52e7062d5fb7cd2a1cd888f2bdea797c95e40e/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
,
Aug 26 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b524d105844e575ee4d00d5a342931903786408 commit 4b524d105844e575ee4d00d5a342931903786408 Author: dschuyler <dschuyler@chromium.org> Date: Thu Sep 08 17:04:18 2016 [MD settings] move the subpage search underline up This CL moves the underline in the subpage search up by two px, to match mocks (request by Alan). BUG= 638453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2321733002 Cr-Commit-Position: refs/heads/master@{#417319} [modify] https://crrev.com/4b524d105844e575ee4d00d5a342931903786408/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
,
Sep 8 2016
The all languages and stored data UI still need to have search added afaik. The control to add the search is ready to be added. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Aug 22 2016Labels: Hotlist-MD-Settings-General
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)