New issue
Advanced search Search tips

Issue 638435 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 922318



Sign in to add a comment

Make javascript: URL navigations always asynchronous

Project Member Reported by dcheng@chromium.org, Aug 17 2016

Issue description

They're actually already async in certain cases: when setting window.location, it's already async. The attached test case prints:

Testing window.location...
a1
c1
Testing HTMLIFrameElement.src...
a2
b2
c2
b1

From a compatibility standpoint...
Making it always async would match Firefox...
Making it always sync would match Edge...

Given that current UA behavior differs wildly, we probably can't make compatibility worse.
 
js-url-test.html
376 bytes View Download

Comment 1 by dcheng@chromium.org, Aug 17 2016

Cc: jochen@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by tkent@chromium.org, Aug 18 2017

Components: Blink>Loader
Status: Available (was: Untriaged)
Note that the current specification has a security issue.
https://github.com/whatwg/html/issues/2591

Comment 4 by tkent@chromium.org, Aug 18 2017

Labels: -M-55 -Hotlist-Recharge-Cold Hotlist-Interop
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -dominicc@chromium.org
Status: Available (was: Untriaged)
Owner: acomminos@fb.com
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d

commit f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d
Author: Andrew Comminos <acomminos@fb.com>
Date: Wed Dec 19 19:58:59 2018

Schedule `javascript:` frame navigations after first load asynchronously

For `javascript:` frame navigations that occur with a ContentFrame()
set, schedule their execution asynchronously via LoadOrRedirectSubframe
rather than executing synchronously. This brings us closer to compliance
with section 7.8.1 of the HTML spec, which suggests that a task is
queued when navigating to a `javascript:` URL.

Bug: 638435
Change-Id: I1bdf59fc281cda6f5852cd40835fcaebc6768a04
Reviewed-on: https://chromium-review.googlesource.com/c/1334589
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#617918}
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/renderer/bindings/core/v8/script_controller.h
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/renderer/core/html/html_frame_element_base.cc
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/fast/events/javascript-uri-navigation-blocked-in-unload-handler-expected.txt
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/fast/events/javascript-uri-navigation-blocked-in-unload-handler.html
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/fast/parser/resources/set-parent-to-javascript-url.html
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/http/tests/security/isolatedWorld/resources/javascript-url-bypass.js
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/loader/iframe-sync-loads-expected.txt
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/virtual/mouseevent_fractional/fast/events/javascript-uri-navigation-blocked-in-unload-handler-expected.txt
[modify] https://crrev.com/f96dbbeb6e8c8f8655061c4e76783c7a8a746d3d/third_party/blink/web_tests/virtual/user-activation-v2/fast/events/javascript-uri-navigation-blocked-in-unload-handler-expected.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24bbe2a6e6a9847af21d7413e769e529515b3ee7

commit 24bbe2a6e6a9847af21d7413e769e529515b3ee7
Author: Nate Chapin <japhet@chromium.org>
Date: Tue Jan 08 17:23:03 2019

content-security-policy/unsafe-hashes/javascript_src_allowed-href-blank.html assumes the javascript url will run in the wrong browsing context

Bug: 638435
Change-Id: I75ae1a26bbbdbd993bfffde38909f3e83013a6cf
Reviewed-on: https://chromium-review.googlesource.com/c/1399546
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620774}
[modify] https://crrev.com/24bbe2a6e6a9847af21d7413e769e529515b3ee7/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/24bbe2a6e6a9847af21d7413e769e529515b3ee7/third_party/blink/web_tests/external/wpt/content-security-policy/unsafe-hashes/javascript_src_allowed-href_blank.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aaeb20f509f4d9975a5ba31cf9d25d01d4a74a4

commit 2aaeb20f509f4d9975a5ba31cf9d25d01d4a74a4
Author: Nate Chapin <japhet@chromium.org>
Date: Thu Jan 10 18:24:21 2019

dom/events/Event-dispatch-click.html shouldn't depend on javascript: urls running synchronously

Bug: 638435
Change-Id: I25e5f54b90651309ced2c5e305c3725a31f8fd07
Reviewed-on: https://chromium-review.googlesource.com/c/1389503
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621648}
[modify] https://crrev.com/2aaeb20f509f4d9975a5ba31cf9d25d01d4a74a4/third_party/blink/web_tests/external/wpt/dom/events/Event-dispatch-click.html

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a5cbbbed80059e1a0dd3e684db88987f9b4234a

commit 0a5cbbbed80059e1a0dd3e684db88987f9b4234a
Author: Nate Chapin <japhet@chromium.org>
Date: Tue Jan 15 23:48:39 2019

Run Javascript urls through the document.

Put them on a timer and have them block the load event. This guarantees
that JS urls will always run asynchronously, improving spec compliance.
It also will allow us to depend far less on NavigationScheduler for
our async navigation needs, hopefully allow us to delete that class
someday soon.

Bug: 638435, 914587
Change-Id: I01ab08640fc22a84f19ef096021c654ef0b96301
Reviewed-on: https://chromium-review.googlesource.com/c/1387448
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622873}
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b0b75172690b363de3975c5540b94ea666ba07

commit 98b0b75172690b363de3975c5540b94ea666ba07
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Jan 16 02:09:30 2019

Revert "Run Javascript urls through the document."

This reverts commit 0a5cbbbed80059e1a0dd3e684db88987f9b4234a.

Reason for revert: Breaks many test suites, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Release%20%28NVIDIA%29/149774 for an example.

Error log is:
[1:1:0115/160946.626469:FATAL:document.h(465)] Check failed: style_engine_.Get().

Original change's description:
> Run Javascript urls through the document.
>
> Put them on a timer and have them block the load event. This guarantees
> that JS urls will always run asynchronously, improving spec compliance.
> It also will allow us to depend far less on NavigationScheduler for
> our async navigation needs, hopefully allow us to delete that class
> someday soon.
>
> Bug: 638435, 914587
> Change-Id: I01ab08640fc22a84f19ef096021c654ef0b96301
> Reviewed-on: https://chromium-review.googlesource.com/c/1387448
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622873}

TBR=dgozman@chromium.org,dcheng@chromium.org,japhet@chromium.org,acomminos@fb.com

Change-Id: I224e717aecf5f8f2c8a71ff72bf47c9fdce20a16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 638435, 914587
Reviewed-on: https://chromium-review.googlesource.com/c/1413894
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623033}
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Blockedon: 922318
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 18 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0

commit ebbcef1f17bc37f5380bd7e87a17016defd1fdd0
Author: Nate Chapin <japhet@chromium.org>
Date: Fri Jan 18 08:21:24 2019

Run Javascript urls through the document, attempt #2

Put them on a timer and have them block the load event. This guarantees
that JS urls will always run asynchronously, improving spec compliance.
It also will allow us to depend far less on NavigationScheduler for
our async navigation needs, hopefully allow us to delete that class
someday soon.

Bug: 638435, 914587,  922318 ,  922330 

Change-Id: I9b72af88009115a55167afa42e7206d54bb5c2c1
Reviewed-on: https://chromium-review.googlesource.com/c/1415312
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624035}
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/parser/xml-error-adopted.xml
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Sign in to add a comment