New issue
Advanced search Search tips

Issue 638425 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Android][Client] Feedback animation texture doesn't look clean

Project Member Reported by yuweih@chromium.org, Aug 16 2016 
Currently the feedback animation texture is transparent black-white-black-transparent black radial gradient, which doesn't look very clean:

* The transparent black-white transition takes 80% of the radius, which means most of the area in the texture is transparent, making the feedback animation less noticeable.
* The animation of intricate pattern doesn't look very well under the OpenGL renderer's linear interpolation.

We can change it to a simpler design, say just a gray circle with a white ring on the outside, and remove all these interleaving black-white transitions. This should make the feedback animation look cleaner.

Comment 1 by yuweih@chromium.org, Aug 18 2016 

What I mean for the second point is the texture looks kind of blurry when showing in large size. The OpenGL renderer implements the feedback animation slightly differently, namely a 512x512 texture will be generated before hand and later scaled (which makes it slightly blurry) to the right size and put on the canvas when we need to show the texture.

Comment 2 by jamiewa...@chromium.org, Aug 18 2016

Owner: yuweih@chromium.org
Status: Assigned (was: Untriaged)
Please put together a prototype so that we can evaluate in context.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d63f07075f833e6dcce793b87a529569f3fe4827

commit d63f07075f833e6dcce793b87a529569f3fe4827
Author: yuweih <yuweih@chromium.org>
Date: Wed Aug 24 20:55:35 2016

[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG= 638425 

Review-Url: https://codereview.chromium.org/2272793003
Cr-Commit-Position: refs/heads/master@{#414141}

[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/res/values/dimens.xml
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/client/gl_cursor_feedback_texture.cc
[modify] https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827/remoting/client/gl_renderer.cc

Comment 5 by yuweih@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)

Comment 6 by ajnolley@chromium.org, Aug 31 2016

Status: Verified (was: Fixed)
Impact animation has been changed to the new schema. Verified in 54.0.2840.6

Comment 7 by yuweih@chromium.org, Oct 19 2016

Labels: M-54
►

Sign in to add a comment