New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638424 link

Starred by 1 user
Status: Fixed
Owner:
█ hush@chromium.org
inactive
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Properly clear and reset the drag and drop states under early out conditions

Project Member Reported by hush@chromium.org, Aug 16 2016 
There are some conditions where we just early exit a DnD operation.

If the DnD states are not cleared, blink thread could be stuck in a state where it ignores inputs, until the drag and drop ends.

For example, on Chrome version 54.0.2828.0 and commandline flag --enable-touch-drag-drop, you can make enter this stuck state by long pressing on an image.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5996d6944ebdca3d0df4c2561f75e1f7b949edf9

commit 5996d6944ebdca3d0df4c2561f75e1f7b949edf9
Author: hush <hush@chromium.org>
Date: Tue Aug 23 00:33:52 2016

End the drag and drop operation properly.

Blink::WebViewImpl will ignore the inputs when it thinks it's doing drag and
drop. As a result, we need to clear the states properly during early outs in
content/ layer.

BUG= 638424 

Review-Url: https://codereview.chromium.org/2242173005
Cr-Commit-Position: refs/heads/master@{#413605}

[modify] https://crrev.com/5996d6944ebdca3d0df4c2561f75e1f7b949edf9/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/5996d6944ebdca3d0df4c2561f75e1f7b949edf9/content/browser/web_contents/web_contents_view_android.cc

Comment 2 by hush@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment