New issue
Advanced search Search tips

Issue 638420 link

Starred by 2 users
Status: Fixed
Owner:
rajendrant@chromium.org
Closed: Oct 2016
Cc:
wifiprefetch-reviews@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add daily prefetch caps

Project Member Reported by twif...@chromium.org, Aug 16 2016 
We should have per-day byte caps on our prefetches, either in addition to or instead of our per-prefetch caps. I don't think it's critical that it be a constant moving 24-hour window -- just "number of bytes since midnight" should be fine (and easier to track).

Comment 1 by twif...@chromium.org, Aug 16 2016 

A simpler possibility which may be good enough: reduce interval from 6h to 12h, so that the per-prefetch cap becomes closer to being a daily cap.

Comment 2 by rajendrant@chromium.org, Sep 2 2016

Owner: rajendrant@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f0b2a973b3940ffe34af8cd3252d07d266fd01

commit f4f0b2a973b3940ffe34af8cd3252d07d266fd01
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Sep 23 22:36:21 2016

Add daily quota for precache

BUG= 638420 

Review-Url: https://codereview.chromium.org/2335913002
Cr-Commit-Position: refs/heads/master@{#420745}

[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/BUILD.gn
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_database.cc
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_database.h
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_session_table.cc
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_session_table.h
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/precache_session_table_unittest.cc
[modify] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/proto/precache.proto
[add] https://crrev.com/f4f0b2a973b3940ffe34af8cd3252d07d266fd01/components/precache/core/proto/quota.proto

Comment 4 by rajendrant@chromium.org, Sep 27 2016

Labels: Merge-Request-54

Comment 5 by dimu@chromium.org, Sep 27 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6

commit cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Sep 27 18:21:10 2016

Add daily quota for precache

BUG= 638420 

Review-Url: https://codereview.chromium.org/2335913002
Cr-Commit-Position: refs/heads/master@{#420745}
(cherry picked from commit f4f0b2a973b3940ffe34af8cd3252d07d266fd01)

Review URL: https://codereview.chromium.org/2369243003 .

Cr-Commit-Position: refs/branch-heads/2840@{#548}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/BUILD.gn
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_database.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_database.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table_unittest.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/proto/precache.proto
[add] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/proto/quota.proto

Comment 7 by twif...@chromium.org, Oct 14 2016

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6

commit cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Sep 27 18:21:10 2016

Add daily quota for precache

BUG= 638420 

Review-Url: https://codereview.chromium.org/2335913002
Cr-Commit-Position: refs/heads/master@{#420745}
(cherry picked from commit f4f0b2a973b3940ffe34af8cd3252d07d266fd01)

Review URL: https://codereview.chromium.org/2369243003 .

Cr-Commit-Position: refs/branch-heads/2840@{#548}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/BUILD.gn
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_database.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_database.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table.h
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/precache_session_table_unittest.cc
[modify] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/proto/precache.proto
[add] https://crrev.com/cc2e2ea9a71f65f38b5f5f7a7184d4d7ad61fcc6/components/precache/core/proto/quota.proto
►

Sign in to add a comment