New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638419 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 640071
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::LayoutFrameSet::layOutAxis

Project Member Reported by ClusterFuzz, Aug 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4732986526531584

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::LayoutFrameSet::layOutAxis
  blink::LayoutFrameSet::layout
  blink::LayoutFrameSet::positionFrames
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=377688:377898

Minimized Testcase (0.42 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv953u_XhU0BLoU9kh0vzhJ4sra7G1sDpaQsWrDK0e3-OWIuVPW-uM9P28AUAwtiqF64vfBkTljYZ6LzP9GSCSjRxLwp5RPNdo-KuIWab_mZCc8ZobT8jJX5S6S2qkY36U932mByd7GTXjXYfN0lLdqpqOjpugg?testcase_id=4732986526531584
<iframe id=tCF2>
    <frameset>
        <frameset cols="50,50">
</iframe>
<script>
    iframes = [].slice.call(document.querySelectorAll('iframe'));
    iframes.forEach(function(iframe) {
        iframe.contentDocument.write(iframe.textContent);
    });
</script>
<style>
.c7 { font-stretch: 83%; min-width: 299585320mm;</style><script>
tCF2.contentDocument.documentElement.style.zoom = 24;
tCF2.setAttribute("class", "c7");
</script>


Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: findit-wrong Te-Logged M-53
Owner: msten...@opera.com
Status: Assigned (was: Untriaged)

Author: mstensho
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/fe283ea1ad33abe251cbb4a921f7f836085bab82
Time: Fri Mar 11 14:19:18 2016
The CL last changed line 724 of file LayoutBlockFlow.cpp, which is stack frame 5.

Author: mstensho
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/fe283ea1ad33abe251cbb4a921f7f836085bab82
Time: Fri Mar 11 14:19:18 2016
The CL last changed line 1209 of file LayoutBlockFlow.cpp, which is stack frame 6.
Labels: Test-Layout

Comment 3 by msten...@opera.com, Aug 17 2016

Components: Blink>Layout
Owner: ----
Status: Available (was: Assigned)
Not caused by my CL. This bug has probably existed since day one. The frame support code still uses int instead of LayoutUnit, and there are int multiplications all over the place.
Cc: rnimmagadda@chromium.org
Owner: darin@chromium.org
Status: Assigned (was: Available)
Author: darin
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/3a60539158ebf574faf764404a2189acbd1d537d
Time: Wed Dec 20 01:49:03 2006
The CL last changed line 222 of file LayoutFrameSet.cpp, which is stack frame 0.

@darin: Could you please look into this issue.

Thank you.

Comment 5 by darin@chromium.org, Aug 18 2016

Owner: e...@chromium.org
Wrong Darin. That is also a change log entry from 2006! Over to eae@ for triage.

Comment 6 by e...@chromium.org, Aug 22 2016

Labels: -OS-Linux -Pri-1 OS-All Pri-2
Status: Available (was: Assigned)
clusterfuzz isn't considering this a security issue and it's not affecting any real world website, lowering priority.

We should probably switch intpoint/size/rect to use saturation arithmetic just as we do for layout.

Comment 7 by e...@chromium.org, Aug 22 2016

Cc: e...@chromium.org glebl@chromium.org ajha@chromium.org
 Issue 635446  has been merged into this issue.

Comment 8 by e...@chromium.org, Aug 23 2016

Mergedinto: 640071
Status: Duplicate (was: Available)
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by ClusterFuzz, Jul 2 2017

ClusterFuzz has detected this issue as fixed in range 483913:483914.

Detailed report: https://clusterfuzz.com/testcase?key=4732986526531584

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::LayoutFrameSet::layOutAxis
  blink::LayoutFrameSet::layout
  blink::LayoutFrameSet::positionFrames
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=377688:377898
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=483913:483914

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4732986526531584


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment