Password manager doesn't update after undo (Ctrl + Z)
Reported by
joshhunt...@gmail.com,
Aug 16 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Go to any authentication page 2. Put in your details, then add some extra text to your username or password. Push Ctrl + Z so that it goes back to your correct username / password. (Note: you might need to click in and out of the input before adding the extra text or it may undo your entire username / password) 3. Submit the form What is the expected behavior? Chrome saves the current username / password. What went wrong? Chrome saves the previous (state before Ctrl + Z) username / password. Did this work before? N/A Chrome version: 52.0.2743.116 Channel: stable OS Version: OS X 10.10.3 Flash Version: Shockwave Flash 22.0 r0
,
Aug 17 2016
,
Aug 17 2016
This is indeed a bug, and can be reproduced, e.g., on https://rsolomakhin.github.io/autofill/. The AutofillAgent::TextFieldDidChangeImpl starts with this: // If the element isn't focused then the changes don't matter. This check is // required to properly handle IME interactions. if (!element.focused()) return; Removing this check for the case of Ctrl+Z might be just the fix we need. We only have to make sure we don't break other things when doing so.
,
Oct 6 2016
Hello! I am new to the project and am looking to make my first contribution. Is it alright if I look into this (if no one else is at the moment)?
,
Oct 10 2016
Welcome to the project! Feel free to try to make contributions. Writing code is perhaps the most difficult way to start contributing to open source. I recommend triaging bugs instead: looking for duplicates, seeing if you can reproduce, etc. I personally like these instructions: https://wiki.gnome.org/Newcomers/. It's about Gnome in particular, but it applies to all open source projects in general.
,
Nov 22 2016
leblanc.joels@ Re: Comment 4: Hi, if you want to contribute to a specific bug, you probably want to change the Status from "Available" to "Assigned", and put you as the Owner in the form below. If not, others may take it.
,
Dec 15 2016
I believe that the handling ctrl+z regardless of focused element might be risky. So, I close this bug. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rnimmagadda@chromium.org
, Aug 17 2016Labels: M-53 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)