Issue 638411 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	----
Closed:	Aug 2016
Cc:	penghuang@chromium.org sadrul@chromium.org mustaq@chromium.org jonr...@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 637914

MouseEvent -> PointerEvent conversion is lossy

Project Member Reported by sky@chromium.org, Aug 16 2016

Issue description

We lose the changed_button_flags. This is particular important in the mash world where we are converting between the two in a number of places.

I also think this effects conversion to blink in such places as BuildWebMouseEventFrom.

Comment 1 by mustaq@chromium.org, Aug 17 2016

Cc: mustaq@chromium.org
Summary: MouseEvent -> PointerEvent conversion is lossy (was: MouseEvent -> PointEvent conversion is lossy)

BuildWebMouseEventFrom should set WebMouseEvent.button in the same way as in MakeWebMouseEventFromAuraEvent.

Comment 2 by penghuang@chromium.org, Aug 23 2016

Blocking: 637914

Exo needs changed_button_flags too.

Comment 3 by penghuang@chromium.org, Aug 23 2016

Cc: penghuang@chromium.org

Comment 4 by penghuang@chromium.org, Aug 23 2016

Sadrul, How to fix this issue? Should we just use MouseEvent in mus or extend PointerEvent to include changed_button_flags? Any suggestions?

Comment 5 by sadrul@chromium.org, Aug 23 2016

Update PointerEvent to include the changed flags.

Comment 6 by jonr...@chromium.org, Aug 23 2016

Could we want these flags in LocatedEvent?

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697f32670af01570942253f0347f789de5d38e55

commit 697f32670af01570942253f0347f789de5d38e55
Author: penghuang <penghuang@chromium.org>
Date: Thu Aug 25 18:36:15 2016

ui/events: Add changed_button_flags_ in ui::PointerEvent.

BUG= 638411 

Review-Url: https://codereview.chromium.org/2270143002
Cr-Commit-Position: refs/heads/master@{#414486}

[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/services/ui/public/cpp/tests/window_tree_client_unittest.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/services/ui/ws/event_dispatcher.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/event.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/event.h
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/event_unittest.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/mojo/OWNERS
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/mojo/event.mojom
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/events/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/697f32670af01570942253f0347f789de5d38e55/ui/views/mus/pointer_watcher_event_router_unittest.cc