New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638406 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
█ w...@chromium.org
liber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

The AVDA thread is not stopped in the common case

Project Member Reported by w...@chromium.org, Aug 16 2016 
During AVDA shutdown we post a task to the AVDA thread to release the MediaCodec right before checking if the thread has pending tasks, and we only stop the thread if there are no pending tasks.

This means the thread will rarely be stopped in practice. We should post a task through the AVDA thread to retry the thread shutdown after the tasks complete.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8e0dfd15ced352e5a4128553397609fb08f4c00

commit d8e0dfd15ced352e5a4128553397609fb08f4c00
Author: watk <watk@chromium.org>
Date: Mon Aug 22 20:44:53 2016

Convert AVDAs thread hang detection to be timer based

Previously AVDAManager counted the number of tasks pending on the construction
thread and considered the thread hung when that number exceeded a threshold.
Now we use a MessageLoop::TaskObserver to watch how long tasks take. If a task
takes longer than 800ms it's considered hung. This mechanism should be more
robust because we don't have to worry about counting the tasks correctly.

BUG= 638406 

Review-Url: https://codereview.chromium.org/2245333004
Cr-Commit-Position: refs/heads/master@{#413527}

[modify] https://crrev.com/d8e0dfd15ced352e5a4128553397609fb08f4c00/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/d8e0dfd15ced352e5a4128553397609fb08f4c00/media/gpu/android_video_decode_accelerator.h

Comment 2 by w...@chromium.org, Aug 24 2016

Status: Fixed (was: Available)
►

Sign in to add a comment