MD Downloads: Add waterfall drop shadow |
|||||
Issue descriptionMD Settings's toolbar has a shadow when you scroll down, indicating that the toolbar is "on top" (closer to the screen) of the page. History and Downloads have no shadow, even when you scroll, making it seem more like the toolbar is fixed and the rest of the page is in a separate container. Should we standardize?
,
Aug 22 2016
We should standardize to have drop shadows beneath toolbars. So add shadows to history and downloads. (polymer's waterfall)
,
Sep 7 2016
@tsergeant, is this bug needed any more? Are History/Settings/Downloads aligned?
,
Sep 7 2016
Settings and History align, Downloads is now the outlier. Updating this bug to suit.
,
Sep 16 2016
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77 commit 7504d90b5f1157b235ec30fbc2d8c89e35bf8d77 Author: dbeam <dbeam@chromium.org> Date: Fri Sep 16 02:50:23 2016 MD Downloads: add "waterfall" shadow (shows when the list is scrolled) R=tsergeant@chromium.org BUG= 638405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2344893006 Cr-Commit-Position: refs/heads/master@{#419081} [modify] https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77/chrome/browser/resources/md_downloads/manager.css [modify] https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77/chrome/browser/resources/md_downloads/manager.js [modify] https://crrev.com/7504d90b5f1157b235ec30fbc2d8c89e35bf8d77/chrome/browser/resources/md_downloads/vulcanized.html
,
Sep 16 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tsergeant@chromium.org
, Aug 17 2016