OfflinePageDownloadBridge memory leak |
||
Issue descriptionThere's a memory leak when Offline Pages is told to download the current page via the menu icon because the bridge doesn't have destroy() called on it.
,
Aug 22 2016
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a286301f5467365276284917019525a663cc0da8 commit a286301f5467365276284917019525a663cc0da8 Author: fgorski <fgorski@chromium.org> Date: Tue Aug 23 23:24:23 2016 [Offline pages] Making sure that destroying the bridge does not leave notification hanging * Preventing memory leak might invalidate the pointer to the bridge on C++ side, which is used to complete save page operation and to update the notification to failed or succeeded. * This patch makes sure that callback is invoked as a static function and is independent of weak ptr. BUG= 638395 R=dimich Review-Url: https://codereview.chromium.org/2271753002 Cr-Commit-Position: refs/heads/master@{#413895} [modify] https://crrev.com/a286301f5467365276284917019525a663cc0da8/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/a286301f5467365276284917019525a663cc0da8/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 20 2016