New issue
Advanced search Search tips

Issue 638350 link

Starred by 1 user
Status: Fixed
Owner:
juncai@chromium.org
Closed: Aug 2016
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add more test code to ChooserDialogCocoaControllerTest and ChooserContentViewTest to test what is displayed in each cell in the table view

Project Member Reported by juncai@chromium.org, Aug 16 2016 
It would be nice to check what is displayed in each cell in the table view in ChooserDialogCocoaControllerTest and ChooserContentViewTest.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c

commit e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c
Author: juncai <juncai@chromium.org>
Date: Wed Aug 17 01:38:09 2016

Update test code to check what is displayed in chooser's table view

This CL added more test code to ChooserDialogCocoaControllerTest and
ChooserContentViewTest to check what is displayed in chooser's table
view.

BUG= 638350 

Review-Url: https://codereview.chromium.org/2256453002
Cr-Commit-Position: refs/heads/master@{#412415}

[modify] https://crrev.com/e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c/chrome/browser/ui/views/chooser_content_view_unittest.cc

Comment 2 by juncai@chromium.org, Aug 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment