Get rid of hardcoded /creds/service_accounts/... paths |
|||||
Issue descriptionWe now have https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/service_account/api.py. It should be used everywhere where '/creds/service_accounts/...' are hardcoded now. Then we'll at least have single place to fix :) Ideally, service_account recipe module should morph into something more general that understands how to talk to Swarming auth daemon (when it exists), so we can stop predeploying private keys on machines.
,
May 15 2017
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/25c9fdc7e7213be80307a1f6712c374028deb6c4 commit 25c9fdc7e7213be80307a1f6712c374028deb6c4 Author: Takuto Ikuta <tikuta@google.com> Date: Tue May 16 03:53:48 2017 Use service_account module in goma module Bug: 638342 Change-Id: I06fb45ccd4bd3c53bb4998561001542b982c2b1c Reviewed-on: https://chromium-review.googlesource.com/505977 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/25c9fdc7e7213be80307a1f6712c374028deb6c4/scripts/slave/recipe_modules/goma/api.py [modify] https://crrev.com/25c9fdc7e7213be80307a1f6712c374028deb6c4/scripts/slave/recipe_modules/goma/__init__.py
,
May 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 21 2018
gclient grep tells me this is definitely not fixed.
,
Oct 19
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by benhenry@chromium.org
, Sep 1 2016