New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638340 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

glGetFragDataLocation works incorrectly on MacOSX

Project Member Reported by zmo@chromium.org, Aug 16 2016

Issue description

If an output variable is an array, say A[COUNT], it only succeeds with glGetFragDataLocation("A"), but fails with glGetFragDataLocation("A[0]"), etc.

For WebGL2, since array location is sequential and continuous, we can workaround by querying location for "A" and compute the location for each element in the array.

However, ARB_blend_func_extended won't work with this bug.

conformance2/programs/gl-get-frag-data-location.html is added to catch this bug.
 

Comment 1 by zmo@chromium.org, Aug 16 2016

Same with glGetFragDataIndex.

Comment 2 by zmo@chromium.org, Aug 16 2016

Blocking: 635081
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712211c39695d69dcda58ce1cc9c63c3c154b1f6

commit 712211c39695d69dcda58ce1cc9c63c3c154b1f6
Author: zmo <zmo@chromium.org>
Date: Tue Aug 16 22:16:15 2016

Work around MacOSX driver bug related with glGetFragDataLocation.

BUG=638340
TEST=gl_tests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2250803002
Cr-Commit-Position: refs/heads/master@{#412355}

[modify] https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6/gpu/command_buffer/service/program_manager.cc
[modify] https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6/gpu/config/gpu_driver_bug_workaround_type.h

Comment 4 by zmo@chromium.org, Aug 18 2016

Blocking: -635081 -429053
Status: ExternalDependency (was: Available)
Keep this open to track the Apple driver bug fix, but with the workaround landed, it should no longer block Chrome from switching to core profile on MacOSX.

Comment 5 by kbr@chromium.org, Sep 10 2016

Filed as Radar 28235295.

Components: -Internals>GPU>WebGL

Sign in to add a comment