Issue 638327 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	robliao@chromium.org
Closed:	Oct 2017
Cc:	robliao@chromium.org dcheng@chromium.org scottmg@chromium.org
Components:	Internals
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	3
Type:	Feature

Blocked on:
issue 749744

Migrate from ScopedComPtr to Microsoft::WRL::ComPtr

Project Member Reported by robliao@chromium.org, Aug 16 2016

Issue description

Now that ComPtr is available, it may be useful to standardize on the WRL provided COM smart pointer so that we have one smart pointer for all COM pointers in Chromium.

Now that ComPtr is available, it may be useful to standardize on the WRL provided COM smart pointer so that we have one smart pointer for all COM pointers in Chromium.

Findings thus far:
1) Things look mostly the same
2) We lose the DCHECK on ReceiveVoid.
3) There's No CreateInstance helper (callers should really just call CoCreateInstance directly).

Now that ComPtr is available, it may be useful to standardize on the WRL provided COM smart pointer so that we have one smart pointer for all COM pointers in Chromium.

Doc:
https://docs.google.com/document/d/17cNzJGKO8a8r1mMDNL7Gycafa-8AMXz54VeAXtow9T4/edit?usp=sharing

Comment 1 by robliao@chromium.org, Mar 29 2017

Components: Internals

Comment 2 by robliao@chromium.org, Mar 29 2017

Description: Show this description

Comment 3 by robliao@chromium.org, Mar 29 2017

Cc: dcheng@chromium.org

Comment 4 by robliao@chromium.org, Mar 29 2017

Owner: robliao@chromium.org

Comment 5 by robliao@chromium.org, Mar 30 2017

Description: Show this description

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2bea96144eaa81bf54ac4a341a9110a015fe918

commit c2bea96144eaa81bf54ac4a341a9110a015fe918
Author: robliao <robliao@chromium.org>
Date: Mon Apr 03 20:56:10 2017

Remove Base Class from ScopedComPtr and Deprecate

Removed scoped_refptr as a superclass of ScopedComPtr and inlined
necessary methods scoped_refptr from to keep the build compiling.

This also starts the train of CLs that deprecates ScopedComPtr in favor of
ComPtr.

BUG= 638327 

Review-Url: https://codereview.chromium.org/2787123006
Cr-Commit-Position: refs/heads/master@{#461531}

[modify] https://crrev.com/c2bea96144eaa81bf54ac4a341a9110a015fe918/base/win/scoped_comptr.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a70ea2c136d0004367deeb08dc335ad36772627

commit 5a70ea2c136d0004367deeb08dc335ad36772627
Author: robliao <robliao@chromium.org>
Date: Tue Apr 04 00:58:24 2017

Add IID_PPV_ARGS_Helper for ScopedComPtr

This allows callers to use IID_PPV_ARGS with ScopedComPtr.
Also moved some of the internal code to use IID_PPV_ARGS directly.

BUG= 638327 

Review-Url: https://codereview.chromium.org/2789273002
Cr-Commit-Position: refs/heads/master@{#461592}

[modify] https://crrev.com/5a70ea2c136d0004367deeb08dc335ad36772627/base/win/scoped_comptr.h
[modify] https://crrev.com/5a70ea2c136d0004367deeb08dc335ad36772627/base/win/scoped_comptr_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25

commit 36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25
Author: robliao <robliao@chromium.org>
Date: Wed Apr 05 22:07:36 2017

Remove ScopedComPtr::iid()

ComPtr does not expose an iid() method and callers should simply use
IID_PPV_ARGS to associate the interface ID with their pointer.

BUG= 638327 

Review-Url: https://codereview.chromium.org/2792173003
Cr-Commit-Position: refs/heads/master@{#462239}

[modify] https://crrev.com/36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25/base/win/scoped_comptr.h
[modify] https://crrev.com/36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25/chrome/browser/google/google_update_win.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9212cb4b406d2ea04de856efeec473fc6276211f

commit 9212cb4b406d2ea04de856efeec473fc6276211f
Author: robliao <robliao@chromium.org>
Date: Thu Apr 06 17:43:39 2017

Rename ScopedComPtr::Release() to ScopedComPtr::Reset()

This renames Release() to Reset() to harmonize with ComPtr::Reset().

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jam@chromium.org, reillyg@chromium.org, kbr@chromium.org, chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2792383003
Cr-Commit-Position: refs/heads/master@{#462534}

[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/base/win/scoped_comptr.h
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/base/win/shortcut.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/media_galleries/win/snapshot_file_details.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/installer/gcapi/gcapi.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/service/cloud_print/print_system_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/capture/video/win/pin_base_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/capture/video/win/video_capture_device_mf_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/remoting/host/setup/win/auth_code_getter.cc
[modify] https://crrev.com/9212cb4b406d2ea04de856efeec473fc6276211f/remoting/host/win/rdp_client_window.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44b907bbf8615ec03c9f97591fec845747c627e

commit b44b907bbf8615ec03c9f97591fec845747c627e
Author: robliao <robliao@chromium.org>
Date: Wed Apr 19 00:28:09 2017

Rename ScopedComPtr::get() to ScopedComPtr::Get()

This renames get() to Get() to harmonize with ComPtr::Get().
Most replacements were performed automatically with clang-tidy.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, kbr@chromium.org, reillyg@chromium.org, rsleevi@chromium.org, sdefresne@chromium.org, thestig@chromium.org, thakis@chromium.org, wez@chromium.org,
Mechanical rename.

Review-Url: https://codereview.chromium.org/2824773002
Cr-Commit-Position: refs/heads/master@{#465432}

[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/base/test/test_shortcut_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/base/win/scoped_comptr.h
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/base/win/shortcut.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/media_galleries/win/mtp_device_operations_util.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/media_galleries/win/portable_device_map_service.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/media_galleries/win/snapshot_file_details.h
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/metrics/antivirus_metrics_provider_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/speech/tts_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/win/jumplist_updater.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/installer/util/legacy_firewall_manager_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/installer/util/shell_util.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/installer/util/wmi.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/service/cloud_print/print_system_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/content/browser/renderer_host/legacy_render_widget_host_win.h
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/audio/win/audio_device_listener_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/audio/win/audio_low_latency_output_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/audio/win/core_audio_util_win_unittest.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/base/win/mf_helpers.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/capture/video/win/filter_base_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/capture/video/win/pin_base_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/capture/video/win/video_capture_device_mf_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/gpu/d3d11_h264_accelerator.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/gpu/d3d11_video_decode_accelerator_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/media/midi/midi_manager_winrt.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/net/http/url_security_manager_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/printing/backend/print_backend_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/printing/backend/win_helper.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/remoting/host/setup/win/auth_code_getter.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/base/dragdrop/os_exchange_data_win_unittest.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/base/win/shell.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/gfx/font_fallback_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/gfx/win/direct_manipulation.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/gfx/win/direct_write.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/gl/gl_angle_util_win.cc
[modify] https://crrev.com/b44b907bbf8615ec03c9f97591fec845747c627e/ui/views/accessibility/native_view_accessibility_win_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9867f09db923dbdb754dc98242d80701c79ffc05

commit 9867f09db923dbdb754dc98242d80701c79ffc05
Author: robliao <robliao@chromium.org>
Date: Fri Apr 21 19:46:39 2017

Migrate IID Coupled Uses of ScopedComPtr::ReceiveVoid() to IID_PPV_ARGS

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=dalecurtis@chromium.org, reillyg@chromium.org, sdefresne@chromium.org, thakis@chromium.org
Mechanical substitutions.

Review-Url: https://codereview.chromium.org/2830893004
Cr-Commit-Position: refs/heads/master@{#466416}

[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/base/win/win_util.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/chrome/browser/metrics/antivirus_metrics_provider_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/chrome/browser/win/jumplist_updater.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/audio/win/audio_low_latency_output_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/9867f09db923dbdb754dc98242d80701c79ffc05/media/midi/midi_manager_winrt.cc

Comment 12 by robliao@chromium.org, Apr 28 2017

Summary: Migrate from ScopedComPtr to Microsoft::WRL::ComPtr (was: Investigate Migration from ScopedComPtr to Microsoft::WRL::ComPtr)

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb

commit 6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb
Author: robliao <robliao@chromium.org>
Date: Fri Apr 28 22:41:17 2017

Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org

Review-Url: https://codereview.chromium.org/2850683002
Cr-Commit-Position: refs/heads/master@{#468163}

[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/base/win/scoped_comptr.h
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/base/win/win_util.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb/ui/gl/gl_angle_util_win.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72

commit ca3a3abe11f55102dbfa923c0d14abed5e2f6b72
Author: robliao <robliao@chromium.org>
Date: Fri May 05 14:04:01 2017

Rename ScopedComPtr::QueryInterface to ScopedComPtr::CopyTo

This renames QueryInterface() to CopyTo() to harmonize with
ComPtr::CopyTo().

Most replacements were performed automatically with clang-tidy.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, kbr@chromium.org, rsleevi@chromium.org, thakis@chromium.org, wez@chromium.org
Mechanical rename.

Review-Url: https://codereview.chromium.org/2864523002
Cr-Commit-Position: refs/heads/master@{#469639}

[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/base/win/scoped_comptr.h
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/chrome/browser/win/jumplist_updater.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/media/gpu/d3d11_video_decode_accelerator_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/ui/gfx/font_fallback_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/ui/gfx/win/direct_write.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/ui/gl/gl_angle_util_win.cc
[modify] https://crrev.com/ca3a3abe11f55102dbfa923c0d14abed5e2f6b72/ui/views/accessibility/native_view_accessibility_win_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4a2186ea71c614e959404ea0e5125ad57d38288

commit c4a2186ea71c614e959404ea0e5125ad57d38288
Author: robliao <robliao@chromium.org>
Date: Mon May 08 18:45:55 2017

Remove ScopedComPtr::IsSameObject()

BUG= 638327 

Review-Url: https://codereview.chromium.org/2865713002
Cr-Commit-Position: refs/heads/master@{#470062}

[modify] https://crrev.com/c4a2186ea71c614e959404ea0e5125ad57d38288/base/win/scoped_comptr.h
[modify] https://crrev.com/c4a2186ea71c614e959404ea0e5125ad57d38288/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/c4a2186ea71c614e959404ea0e5125ad57d38288/ui/views/accessibility/native_view_accessibility_win_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/310fa98b9861be3c4b87fd8fd9d925dc83268bc3

commit 310fa98b9861be3c4b87fd8fd9d925dc83268bc3
Author: robliao <robliao@chromium.org>
Date: Thu May 11 17:14:00 2017

Rename ScopedComPtr::Receive to ScopedComPtr::GetAddressOf

This renames Receive() to GetAddressOf() to harmonize with
ComPtr::GetAddressOf().

Most replacements were performed automatically with clang-tidy.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2870263002
Cr-Commit-Position: refs/heads/master@{#470987}

[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/base/win/scoped_comptr.h
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/media_galleries/win/mtp_device_operations_util.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/metrics/antivirus_metrics_provider_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/platform_util_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/prefs/incognito_mode_prefs.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/speech/tts_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/win/jumplist_updater.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/installer/util/legacy_firewall_manager_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/installer/util/wmi.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/service/cloud_print/print_system_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/chrome/utility/shell_handler_impl_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/gpu/ipc/service/direct_composition_surface_win_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/audio/win/core_audio_util_win_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/audio/win/device_enumeration_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/base/win/mf_helpers.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/capture/video/win/video_capture_device_mf_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/gpu/d3d11_h264_accelerator.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/gpu/d3d11_video_decode_accelerator_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/media/midi/midi_manager_winrt.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/net/http/url_security_manager_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/printing/backend/print_backend_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/printing/backend/win_helper.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/base/dragdrop/os_exchange_data_win_unittest.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/base/win/shell.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/gfx/font_fallback_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/gfx/win/direct_manipulation.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/gfx/win/direct_write.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/gl/gl_angle_util_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/shell_dialogs/select_file_dialog_win.cc
[modify] https://crrev.com/310fa98b9861be3c4b87fd8fd9d925dc83268bc3/ui/views/accessibility/native_view_accessibility_win_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7452d2eaafcf78e874f5f2eda336228e45f8d1e

commit f7452d2eaafcf78e874f5f2eda336228e45f8d1e
Author: robliao <robliao@chromium.org>
Date: Wed May 17 17:17:20 2017

Add Missing Includes to mf_helpers.h

mf_helpers.h was previously relying on scoped_comptr.h for selected
definitions. scoped_comptr.h in the future will not include
base/logging.h and base/macros.h, breaking this file.

BUG= 638327 
TBR=dalecurtis@chromium.org
Trivial change.

Review-Url: https://codereview.chromium.org/2892533002
Cr-Commit-Position: refs/heads/master@{#472482}

[modify] https://crrev.com/f7452d2eaafcf78e874f5f2eda336228e45f8d1e/media/base/win/mf_helpers.h

Project Member

Comment 18 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7956aa916bca6ef95c851e08494cdf7466b5d3c

commit a7956aa916bca6ef95c851e08494cdf7466b5d3c
Author: robliao <robliao@chromium.org>
Date: Wed May 17 19:10:54 2017

Remove ScopedComPtr::QueryFrom()

This is better expressed as calling QueryInterface() or CopyTo()
directly on the incoming object.

This is a mechanical refactor moving the QueryFrom() argument out and
calling QueryInterface() or CopyTo() with the ScopedComPtr as the
argument.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2885063003
Cr-Commit-Position: refs/heads/master@{#472522}

[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/test/test_shortcut_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/win/scoped_comptr.h
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/win/shortcut.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/midi/midi_manager_winrt.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/ui/gfx/win/direct_manipulation.cc

Project Member

Comment 19 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7956aa916bca6ef95c851e08494cdf7466b5d3c

commit a7956aa916bca6ef95c851e08494cdf7466b5d3c
Author: robliao <robliao@chromium.org>
Date: Wed May 17 19:10:54 2017

Remove ScopedComPtr::QueryFrom()

This is better expressed as calling QueryInterface() or CopyTo()
directly on the incoming object.

This is a mechanical refactor moving the QueryFrom() argument out and
calling QueryInterface() or CopyTo() with the ScopedComPtr as the
argument.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2885063003
Cr-Commit-Position: refs/heads/master@{#472522}

[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/test/test_shortcut_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/win/scoped_comptr.h
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/base/win/shortcut.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/media/midi/midi_manager_winrt.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/a7956aa916bca6ef95c851e08494cdf7466b5d3c/ui/gfx/win/direct_manipulation.cc

Project Member

Comment 20 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9bfd648536ce835bb62026506bd29395de3f88

commit eb9bfd648536ce835bb62026506bd29395de3f88
Author: robliao <robliao@chromium.org>
Date: Thu May 18 17:35:16 2017

Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org, rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org, nicholss@chromium.org,
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2887243002
Cr-Commit-Position: refs/heads/master@{#472858}

[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/test/test_shortcut_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/scoped_comptr.h
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/shortcut.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/content/common/quarantine/quarantine_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/device_enumeration_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/setup/win/auth_code_getter.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/ui/gfx/win/direct_manipulation.cc

Project Member

Comment 21 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9bfd648536ce835bb62026506bd29395de3f88

commit eb9bfd648536ce835bb62026506bd29395de3f88
Author: robliao <robliao@chromium.org>
Date: Thu May 18 17:35:16 2017

Remove ScopedComPtr::CreateInstance()

This is better expressed as directly calling CoCreateInstance().

This change is a mechanical refactor from
ScopedComPtr::CreateInstance() to CoCreateInstance().

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, jam@chromium.org, reillyg@chromium.org, rsleevi@chromium.org, sdefresne@chromium.org, thakis@chromium.org, nicholss@chromium.org,
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2887243002
Cr-Commit-Position: refs/heads/master@{#472858}

[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/test/test_shortcut_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/scoped_comptr.h
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/base/win/shortcut.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/content/common/quarantine/quarantine_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/audio/win/device_enumeration_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/remoting/host/setup/win/auth_code_getter.cc
[modify] https://crrev.com/eb9bfd648536ce835bb62026506bd29395de3f88/ui/gfx/win/direct_manipulation.cc

Project Member

Comment 22 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d2438074669d3251deee6d17a9e6692ffcff297

commit 6d2438074669d3251deee6d17a9e6692ffcff297
Author: robliao <robliao@chromium.org>
Date: Fri May 19 17:15:23 2017

Remove Interface ID Template Parameter from ScopedComPtr

ScopedComPtr no longer uses this template parameter.

BUG= 638327 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, nicholss@chromium.org, thakis@chromium.org,
Mechanical refactor.

Review-Url: https://codereview.chromium.org/2889263002
Cr-Commit-Position: refs/heads/master@{#473222}

[modify] https://crrev.com/6d2438074669d3251deee6d17a9e6692ffcff297/base/win/scoped_comptr.h
[modify] https://crrev.com/6d2438074669d3251deee6d17a9e6692ffcff297/base/win/scoped_comptr_unittest.cc
[modify] https://crrev.com/6d2438074669d3251deee6d17a9e6692ffcff297/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/6d2438074669d3251deee6d17a9e6692ffcff297/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/6d2438074669d3251deee6d17a9e6692ffcff297/remoting/host/setup/win/auth_code_getter.h

Project Member

Comment 23 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02950edae45e711363532457ec564092ca1666f6

commit 02950edae45e711363532457ec564092ca1666f6
Author: robliao <robliao@chromium.org>
Date: Tue May 23 18:29:02 2017

Rename ScopedComPtr::swap() to ScopedComPtr::Swap()

This renames swap() to Swap() to harmonize with ComPtr::Swap().

BUG= 638327 
TBR=thestig@chromium.org
Mechanical rename.

Review-Url: https://codereview.chromium.org/2895313002
Cr-Commit-Position: refs/heads/master@{#473991}

[modify] https://crrev.com/02950edae45e711363532457ec564092ca1666f6/base/win/scoped_comptr.h
[modify] https://crrev.com/02950edae45e711363532457ec564092ca1666f6/chrome/browser/google/google_update_win.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c3ff2f544c82f66cc75087c63ddac145a6e984

commit 25c3ff2f544c82f66cc75087c63ddac145a6e984
Author: Robert Liao <robliao@chromium.org>
Date: Wed May 24 02:49:32 2017

Enforce nullptr Usage for ScopedComPtr

ComPtr expects nullptr and does not accept NULL.

BUG= 638327 
TBR=dalecurtis@chromium.org, thestig@chromium.org
Mechanical refactor.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib32804a3171df43697d42198fe08c93b355d8f1b
Reviewed-on: https://chromium-review.googlesource.com/513443
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474138}
[modify] https://crrev.com/25c3ff2f544c82f66cc75087c63ddac145a6e984/base/win/scoped_comptr.h
[modify] https://crrev.com/25c3ff2f544c82f66cc75087c63ddac145a6e984/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/25c3ff2f544c82f66cc75087c63ddac145a6e984/chrome/installer/util/legacy_firewall_manager_win.cc
[modify] https://crrev.com/25c3ff2f544c82f66cc75087c63ddac145a6e984/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/25c3ff2f544c82f66cc75087c63ddac145a6e984/media/gpu/dxva_video_decode_accelerator_win.cc

Comment 25 by robliao@chromium.org, Jul 6 2017

Status: Started (was: Available)

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733f285184d55a53a3f020085eca2eae4e1ac0f8

commit 733f285184d55a53a3f020085eca2eae4e1ac0f8
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 25 17:49:24 2017

Add ScopedComPtrRef::operator typename T::InterfaceType**()

This introduces an equivalent ambiguity from ComPtr when casting the
result of ScopedComPtr::operator& to a void*.

Callers should use GetAddressOf().

BUG= 638327 
TBR=kbr@chromium.org
Refactor change.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie9999c8c0e99a9b0010261d8928afaec221599a2
Reviewed-on: https://chromium-review.googlesource.com/583988
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489359}
[modify] https://crrev.com/733f285184d55a53a3f020085eca2eae4e1ac0f8/base/win/scoped_comptr.h
[modify] https://crrev.com/733f285184d55a53a3f020085eca2eae4e1ac0f8/ui/gl/gl_angle_util_win.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6154970933119fabacb6ea66cae9de58cb194a80

commit 6154970933119fabacb6ea66cae9de58cb194a80
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 25 18:02:05 2017

Remove Unavailable C++ Operators from ScopedComPtr

This harmonizes the available operators between ScopedComPtr and
ComPtr.

BUG= 638327 
TBR=dmazzoni@chromium.org, kbr@chromium.org
Refactor changes.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd17bec1d2707baf516e97eb7902100606663149
Reviewed-on: https://chromium-review.googlesource.com/584088
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489364}
[modify] https://crrev.com/6154970933119fabacb6ea66cae9de58cb194a80/base/win/scoped_comptr.h
[modify] https://crrev.com/6154970933119fabacb6ea66cae9de58cb194a80/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/6154970933119fabacb6ea66cae9de58cb194a80/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/6154970933119fabacb6ea66cae9de58cb194a80/gpu/ipc/service/direct_composition_surface_win_unittest.cc
[modify] https://crrev.com/6154970933119fabacb6ea66cae9de58cb194a80/ui/accessibility/platform/ax_platform_node_win_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b31960eae3a13721e8b167b7df7124bcbf60134c

commit b31960eae3a13721e8b167b7df7124bcbf60134c
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 25 21:50:52 2017

Alias ScopedComPtr<T> to ComPtr<T>

BUG= 638327 
TBR=gab@chromium.org
base/BUILD.gn change.

Change-Id: I1899bb25e996a8031b167cbd09b81cd0d43e4fef
Reviewed-on: https://chromium-review.googlesource.com/584089
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489452}
[modify] https://crrev.com/b31960eae3a13721e8b167b7df7124bcbf60134c/base/BUILD.gn
[modify] https://crrev.com/b31960eae3a13721e8b167b7df7124bcbf60134c/base/win/scoped_comptr.h
[delete] https://crrev.com/3af153f48e439140eeeed51e800a4526364a7688/base/win/scoped_comptr_unittest.cc

Comment 29 by cwallez@chromium.org, Jul 27 2017

Blockedon: 749744

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0771c29b98e31644b358997ff92806a067bcafbe

commit 0771c29b98e31644b358997ff92806a067bcafbe
Author: Robert Liao <robliao@chromium.org>
Date: Tue Oct 17 02:40:42 2017

Convert //base to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=dcheng@chromium.org

Change-Id: I211c1627b5aa7ee7be9fc68e057243c64d8748dc
Reviewed-on: https://chromium-review.googlesource.com/722103
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509236}
[modify] https://crrev.com/0771c29b98e31644b358997ff92806a067bcafbe/base/test/test_shortcut_win.cc
[modify] https://crrev.com/0771c29b98e31644b358997ff92806a067bcafbe/base/win/scoped_variant.h
[modify] https://crrev.com/0771c29b98e31644b358997ff92806a067bcafbe/base/win/shortcut.cc
[modify] https://crrev.com/0771c29b98e31644b358997ff92806a067bcafbe/base/win/win_util.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a

commit fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a
Author: Robert Liao <robliao@chromium.org>
Date: Tue Oct 17 16:23:27 2017

Convert //services to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=rockot@chromium.org

Change-Id: If7ad654a17f2352fd57b27949b732b5f0529e597
Reviewed-on: https://chromium-review.googlesource.com/722283
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509404}
[modify] https://crrev.com/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a/services/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a/services/device/generic_sensor/platform_sensor_provider_win.h
[modify] https://crrev.com/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a/services/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/fb4d6a70c11ee1dde35b24f6ade2dd874bd6bf4a/services/device/generic_sensor/platform_sensor_reader_win.h

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2bc703d087081f2e0aba8d18871aa10d53511da

commit b2bc703d087081f2e0aba8d18871aa10d53511da
Author: Robert Liao <robliao@chromium.org>
Date: Tue Oct 17 20:52:35 2017

Convert //chrome to use ComPtr

This is a mostly automated refactor.

BUG= 638327 

Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I9260d87a5b275ff62b40ac90065abc439b4215c7
Reviewed-on: https://chromium-review.googlesource.com/723591
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509520}
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/download/download_status_updater_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/download/trusted_sources_manager_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/first_run/upgrade_util_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/google/google_update_win.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/google/google_update_win_unittest.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/mtp_device_operations_util.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/mtp_device_operations_util.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/portable_device_map_service.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/media_galleries/win/snapshot_file_details.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/metrics/antivirus_metrics_provider_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/platform_util_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/prefs/incognito_mode_prefs.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/speech/tts_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ssl/captive_portal_helper_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ui/views/frame/taskbar_decorator_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/ui/views/tabs/window_finder_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/win/jumplist_updater.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/win/jumplist_updater.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/browser/win/taskbar_icon_finder.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/gcapi/gcapi.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/util/advanced_firewall_manager_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/util/advanced_firewall_manager_win.h
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/util/advanced_firewall_manager_win_unittest.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/util/shell_util.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/installer/util/wmi.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/service/cloud_print/print_system_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/utility/importer/ie_importer_win.cc
[modify] https://crrev.com/b2bc703d087081f2e0aba8d18871aa10d53511da/chrome/utility/shell_handler_impl_win.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c88f99d1065f2d36067b8ef912ac0c3435d592ef

commit c88f99d1065f2d36067b8ef912ac0c3435d592ef
Author: Robert Liao <robliao@chromium.org>
Date: Tue Oct 17 21:48:33 2017

Convert //device, //gpu, //net, and //printing to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=reillyg@chromium.org, kbr@chromium.org, rsleevi@chromium.org, thestig@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I160373c241f64d73e12ca6421d849a23a90f9fff
Reviewed-on: https://chromium-review.googlesource.com/723786
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509547}
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/device/sensors/data_fetcher_shared_memory.h
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/config/gpu_info_collector_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/ipc/service/direct_composition_child_surface_win.h
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/gpu/ipc/service/direct_composition_surface_win_unittest.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/net/http/url_security_manager_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/printing/backend/print_backend_win.cc
[modify] https://crrev.com/c88f99d1065f2d36067b8ef912ac0c3435d592ef/printing/backend/win_helper.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28200c1611ecebd029de9a0caf2a7fda3a7d5c47

commit 28200c1611ecebd029de9a0caf2a7fda3a7d5c47
Author: Robert Liao <robliao@chromium.org>
Date: Tue Oct 17 23:30:28 2017

Convert //ui to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=sky@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9da8b34dc748d427bcdbe446878461b00bdbda93
Reviewed-on: https://chromium-review.googlesource.com/723867
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509591}
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/accessibility/platform/ax_platform_node_win.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/accessibility/platform/ax_system_caret_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/accessibility/platform/ax_system_caret_win.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/base/dragdrop/os_exchange_data_provider_win.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/base/dragdrop/os_exchange_data_win_unittest.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/base/ime/win/imm32_manager.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gfx/font_fallback_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gfx/win/direct_manipulation.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gfx/win/direct_manipulation.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gfx/win/direct_write.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gl/gl_angle_util_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gl/gl_angle_util_win.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gl/gl_image_dxgi.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/gl/gl_image_dxgi.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/shell_dialogs/select_file_dialog_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/accessibility/native_view_accessibility_win.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/accessibility/native_view_accessibility_win_unittest.cc
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/view.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/win/fullscreen_handler.h
[modify] https://crrev.com/28200c1611ecebd029de9a0caf2a7fda3a7d5c47/ui/views/win/hwnd_message_handler.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a37835650952a3da4e73f8de16879500e8080ee

commit 1a37835650952a3da4e73f8de16879500e8080ee
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 18 01:31:17 2017

Convert //remoting to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=garykac@chromium.org

Change-Id: I579160fb7c69c7b5cbc77e1d8349e144320319bd
Reviewed-on: https://chromium-review.googlesource.com/724261
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509645}
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/audio_capturer_win.cc
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/audio_capturer_win.h
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/setup/win/auth_code_getter.h
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/audio_volume_filter_win.h
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/default_audio_device_change_detector.cc
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/default_audio_device_change_detector.h
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/rdp_client_window.cc
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/rdp_client_window.h
[modify] https://crrev.com/1a37835650952a3da4e73f8de16879500e8080ee/remoting/host/win/rdp_desktop_session.h

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7c9a1c6c19542a5bbd9ea430dd6125906b62e5f

commit c7c9a1c6c19542a5bbd9ea430dd6125906b62e5f
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 18 01:41:31 2017

Convert the C++ Style Guide Away from scoped_comptr.h

scoped_comptr.h is going away.

BUG= 638327 

Change-Id: Iedfc41cda41e717eda28f593b129207c3749891e
Reviewed-on: https://chromium-review.googlesource.com/724232
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509647}
[modify] https://crrev.com/c7c9a1c6c19542a5bbd9ea430dd6125906b62e5f/styleguide/c++/c++.md

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83010ec37757216dbf1b99039ad37a7b058b915

commit d83010ec37757216dbf1b99039ad37a7b058b915
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 18 02:43:22 2017

Convert //content and //components to use ComPtr

This is a mostly automated refactor.

BUG= 638327 
TBR=jam@chromium.org, sdefresne@chromium.org

Change-Id: I855377dae3464f268c02595269cc8f96341ad593
Reviewed-on: https://chromium-review.googlesource.com/724161
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509665}
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/browser_accessibility_manager_win.h
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/browser/renderer_host/legacy_render_widget_host_win.h
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/common/quarantine/quarantine_win.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/d83010ec37757216dbf1b99039ad37a7b058b915/content/renderer/renderer_main_platform_delegate_win.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87d75a09e745c54e5108d7bc1fd4dafcf8453469

commit 87d75a09e745c54e5108d7bc1fd4dafcf8453469
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 18 19:10:01 2017

Convert //media to use ComPtr

This is a mostly automated refactor with a bit of cleanup.

BUG= 638327 
TBR=dalecurtis@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1ea4929eaeefafe28192acf29c350905c30b2470
Reviewed-on: https://chromium-review.googlesource.com/724180
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509828}
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_device_listener_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_device_listener_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_low_latency_output_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/audio_low_latency_output_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/core_audio_util_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/core_audio_util_win_unittest.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/audio/win/device_enumeration_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/base/win/mf_helpers.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/base/win/mf_helpers.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/mac/video_capture_device_decklink_mac.mm
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/filter_base_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/pin_base_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/video_capture_device_mf_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/video_capture_device_mf_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/capture/video/win/video_capture_device_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/d3d11_h264_accelerator.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/d3d11_h264_accelerator.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/d3d11_video_decode_accelerator_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/d3d11_video_decode_accelerator_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/media_foundation_video_encode_accelerator_win.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/windows/d3d11_video_decoder_impl.cc
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/gpu/windows/d3d11_video_decoder_impl.h
[modify] https://crrev.com/87d75a09e745c54e5108d7bc1fd4dafcf8453469/media/midi/midi_manager_winrt.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3fcf416513f0c582b3f89c9d47e15f28214a40b

commit f3fcf416513f0c582b3f89c9d47e15f28214a40b
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 18 21:12:36 2017

Remove ScopedComPtr and scoped_comptr.h

This completes the migration from ScopedComPtr to Microsoft::WRL::ComPtr.

BUG= 638327 
TBR=dcheng@chromium.org
Build file change.

Change-Id: Iec1047e69dea9913db80cd0cfac50ea36b7fc947
Reviewed-on: https://chromium-review.googlesource.com/726461
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509875}
[modify] https://crrev.com/f3fcf416513f0c582b3f89c9d47e15f28214a40b/base/BUILD.gn
[delete] https://crrev.com/0036dfe09c6e86da7865e32de36cfade1341d9c8/base/win/scoped_comptr.h

Comment 40 by robliao@chromium.org, Oct 18 2017

Status: Fixed (was: Started)

►

Issue 638327 link

Issue metadata

Migrate from ScopedComPtr to Microsoft::WRL::ComPtr

Issue description

Comment 1 by robliao@chromium.org, Mar 29 2017

Comment 1 Deleted

Comment 2 by robliao@chromium.org, Mar 29 2017

Comment 2 Deleted

Comment 3 by robliao@chromium.org, Mar 29 2017

Comment 3 Deleted

Comment 4 by robliao@chromium.org, Mar 29 2017

Comment 4 Deleted

Comment 5 by robliao@chromium.org, Mar 30 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 3 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 4 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 5 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Apr 6 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 19 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 21 2017

Comment 11 Deleted

Comment 12 by robliao@chromium.org, Apr 28 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Apr 28 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, May 5 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, May 8 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, May 11 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, May 17 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, May 17 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, May 17 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, May 18 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, May 18 2017

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, May 19 2017

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, May 23 2017

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, May 24 2017

Comment 24 Deleted

Comment 25 by robliao@chromium.org, Jul 6 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Jul 25 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Jul 25 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Jul 25 2017

Comment 28 Deleted

Comment 29 by cwallez@chromium.org, Jul 27 2017

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Oct 17 2017

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Oct 17 2017

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Oct 17 2017

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Oct 17 2017

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Oct 17 2017

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Oct 18 2017

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Oct 18 2017

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Oct 18 2017

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Oct 18 2017

Comment 38 Deleted