New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638316 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PermissionReporterBrowserTest.PermissionActionReporting" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 16 2016

Issue description

"PermissionReporterBrowserTest.PermissionActionReporting" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdQZXJtaXNzaW9uUmVwb3J0ZXJCcm93c2VyVGVzdC5QZXJtaXNzaW9uQWN0aW9uUmVwb3J0aW5nDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by bsep@chromium.org, Aug 16 2016

Based on the dashboard this looks like it's been flaky for a long time. I will disable the test.

Comment 2 by bsep@chromium.org, Aug 17 2016

Components: Services>Safebrowsing
Labels: -Sheriff-Chromium
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
Created https://codereview.chromium.org/2253773002 to disable the test. Assigning to tsergeant@ as you touched the test recently, hopefully you know a good person to look at this.
Cc: tsergeant@chromium.org
Owner: kcaratt...@chromium.org
I'm not familiar with this test. Kendra, is this related to Stefano's changes?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483f8c07a196275bd288841699db03f67aa87299

commit 483f8c07a196275bd288841699db03f67aa87299
Author: bsep <bsep@chromium.org>
Date: Wed Aug 17 00:40:34 2016

Disable PermissionActionReporting due to flakiness.

TBR=tsergeant
BUG= 638316 

Review-Url: https://codereview.chromium.org/2253773002
Cr-Commit-Position: refs/heads/master@{#412399}

[modify] https://crrev.com/483f8c07a196275bd288841699db03f67aa87299/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7476914d264aac8ff5d809d342a6f114b8f7f8dc

commit 7476914d264aac8ff5d809d342a6f114b8f7f8dc
Author: kcarattini <kcarattini@chromium.org>
Date: Thu Aug 25 02:12:20 2016

Permission Action Reporting: Fix flaky Browsertest

This is my attempt to fix the flakiness of this browsertest by having the UI thread wait for the report to be sent on the IO thread.

BUG= 613883 , 638316 

Review-Url: https://codereview.chromium.org/2250163003
Cr-Commit-Position: refs/heads/master@{#414252}

[modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/mock_permission_report_sender.cc
[modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/mock_permission_report_sender.h
[modify] https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Comment 6 by vakh@chromium.org, Aug 26 2016

Labels: SafeBrowsing-Triaged
Status: Fixed (was: Assigned)
I believe this is fixed.

Sign in to add a comment