New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638306 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

get_mem_total(): use HWID lookup to get physical RAM size

Project Member Reported by grundler@chromium.org, Aug 16 2016

Issue description

https://chromium-review.googlesource.com/#/c/359631/

further cripples a relatively useless test. Since firmware is generally responsible for memory detection (and advertising that to the linux kernel), initially assigning to firmware test team.

Dmitry's suggestion sounds reasonable to me:
> I wonder if we should have a dictionary of "exceptional" boards, or somehow detect "full" chrome devices vs appliances.

I am proposing use of hwid (e.g. "GALE A2A-A2A-A2A-A2Q-A9G") to index into a table so get_mem_total() knows exactly what memory this hwid should have. Any given HWID should have unique mem size associated. Changing the installed RAM usually involves soldering chips. (Exception: AFIAK,only chromeboxes use SO-DIMMs but some older chromebooks might too - solution might be to return a list of acceptable RAM sizes).

If no entry exists, fail the test, then manually (and eventually automatically) create an entry. If one exists, fail if the reported physical memory ranges don't match.

While hand curation of the initial list is required, it's the only way I can see to enforce consistent and accurate discovery of physical memory.
 

Comment 1 by ra...@google.com, Aug 16 2016

There's some board-specific information on a per-platform basis in third_party/hdctools/servo/drv now that tracks info like which GPIO pins do what and how to power cycle the specific device. Maybe it would make sense to keep all the board-specific info in one place.

Comment 2 by dchan@chromium.org, Dec 3 2016

Cc: dchan@chromium.org
Owner: ----
there are lots and lots of HWID. Why getting the info from /proc/meminfo is not sufficient /
Components: Infra>Client>ChromeOS
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.

Sign in to add a comment