New issue
Advanced search Search tips

Issue 638305 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Aug 2016
Cc:
lambroslambrou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Android] Remove code that was replaced by the OpenGL renderer

Project Member Reported by joedow@chromium.org, Aug 16 2016 
Just a placeholder bug to track the removal of the old classes (such as DesktopView).  Also, it may make sense to rename the "GL*" classes since there will only be one renderer.

We should do this for the current release (M54) if possible.

Comment 1 by yuweih@chromium.org, Aug 17 2016

Cc: lambroslambrou@chromium.org
lambroslambrou@ Shall we also remove the cardboard code? It has dependency on JniDisplayHandler and probably need to be removed first...

Comment 2 by yuweih@chromium.org, Aug 17 2016

Blockedon: 638655

Comment 3 by joedow@chromium.org, Aug 17 2016 

SGTM, less code, fewer bugs :)

Comment 4 by yuweih@chromium.org, Aug 17 2016 

BTW after using the new OpenGL renderer, the display thread is no longer exposed to the Java code. We can probably remove locks ("synchronized(...)") in *InputStrategy, *InputHandler, etc.

Comment 5 by yuweih@chromium.org, Aug 18 2016

Blockedon: -638655
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70

commit 6e1a8ab14a0babc5600a6d3d6f2557557de3ac70
Author: yuweih <yuweih@chromium.org>
Date: Thu Aug 18 01:19:54 2016

[Remoting Android] Remove old renderer code

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG= 638305 

Review-Url: https://codereview.chromium.org/2256943002
Cr-Commit-Position: refs/heads/master@{#412716}

[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/BUILD.gn
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/client_java_tmpl.gni
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/InputStrategyInterface.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/PaintEventParameter.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/jni/Display.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/chromoting_jni_instance.cc
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/jni_client.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_display_handler.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_display_handler.h
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_video_renderer.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_video_renderer.h
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/remoting_jni_registrar.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016

Labels: merge-merged-2832
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70

commit 6e1a8ab14a0babc5600a6d3d6f2557557de3ac70
Author: yuweih <yuweih@chromium.org>
Date: Thu Aug 18 01:19:54 2016

[Remoting Android] Remove old renderer code

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG= 638305 

Review-Url: https://codereview.chromium.org/2256943002
Cr-Commit-Position: refs/heads/master@{#412716}

[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/BUILD.gn
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/client_java_tmpl.gni
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/InputStrategyInterface.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/PaintEventParameter.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/android/java/src/org/chromium/chromoting/jni/Display.java
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/chromoting_jni_instance.cc
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/jni_client.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_display_handler.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_display_handler.h
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_video_renderer.cc
[delete] https://crrev.com/1d326f8d88bace71f4f1e749a9729dcd3224bca0/remoting/client/jni/jni_video_renderer.h
[modify] https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70/remoting/client/jni/remoting_jni_registrar.cc

Comment 8 by yuweih@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment