NQE should use the connection type to estimate the network quality at start time |
|||||
Issue descriptionNQE should use the default estimates derived from the connection type to estimate the network quality at start time. Right now, the default estimates are provided to NQE through field trial. NQE uses the default estimates when network quality estimates from organic traffic are unavailable. The default estimates should be hard coded in NQE, so that those default estimates are also available to Cronet and its embedders.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/286d35bb3f13b27ada977c535d35fbe3977b9426 commit 286d35bb3f13b27ada977c535d35fbe3977b9426 Author: tbansal <tbansal@chromium.org> Date: Wed Nov 16 21:58:56 2016 NQE: Notify observer as soon as it is added When an EffectiveConnectionTypeObserver or an RTTAndThroughputEstimatesObserver is added to NetworkQualityEstimator (NQE), it is notified of the current effective connection type or current RTT/throughput estimates. Doing this makes the API simpler (the caller does not have to call Get*() functions when registering as an observer). It also reduces the need of exposing both Get*() and Add*() APIs to different layers of Chromium. BUG= 638304 Review-Url: https://codereview.chromium.org/2491703003 Cr-Commit-Position: refs/heads/master@{#432637} [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/net/nqe/network_quality_estimator.h [modify] https://crrev.com/286d35bb3f13b27ada977c535d35fbe3977b9426/net/nqe/network_quality_estimator_unittest.cc
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e71312541dfbef6a53b0dd81923e9db1816dfc36 commit e71312541dfbef6a53b0dd81923e9db1816dfc36 Author: tbansal <tbansal@chromium.org> Date: Fri Dec 09 01:00:16 2016 NQE: Add default RTT and throughput observations Add default estimates for different connection types in the network quality estimator (NQE). Putting the estimates in the src code itself makes them accessible for Cronet embedders, and simplies the field trial configs. Additionally, RTT and throughput observers are notified of the default observations as soon as they are added CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG= 638304 Review-Url: https://codereview.chromium.org/2481373004 Cr-Commit-Position: refs/heads/master@{#437396} [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_id.h [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator.h [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/e71312541dfbef6a53b0dd81923e9db1816dfc36/net/nqe/network_quality_estimator_unittest.cc
,
Dec 12 2016
,
Feb 13 2017
,
Feb 14 2017
,
Mar 18 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbansal@chromium.org
, Nov 8 2016