New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638302 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android browser CPM dropped dramatically, but is it real?

Project Member Reported by yfried...@chromium.org, Aug 16 2016

Issue description

Looking at chromedash, the graph for stable looks great:
https://chromedash.googleplex.com/dashboard?dashboard=android-stability

Cross-checked against overall crash rate: https://plx.corp.google.com/script/#a=qo%7Ci=google%253A%253Ascript_bb._ae0c45_49e8_439d_b2e1_738396e06520  (note: change "Chrome" to "Chrome_Android") shows no appreciable change

Looking at browser top crashes: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&compProp=product.Version&v1=51.0.2704.81&v2=52.0.2743.98

content::CompositorImpl::DidFailToInitializeOutputSurface has shrunk considerably.

Wild guess: could this be at all related to spitzer (in a positive way)? Perhaps there's less crashes or even OOMs from not using the android media player from the browser process? 
 
Cc: khushals...@chromium.org
+khushal who moved code around a bit there.

It might be that a signature changed. Or his changes might have improved some recovery.
Ya, I was wondering about a signature change but don't see a corresponding shift on the browser breakdown. content::NavigationControllerImpl::RendererDidNavigateAutoSubframe (the one big increase) isn't a browser crash - it's a "dump without logging"

Also looking at GPU:
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27gpu-process%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&compProp=product.Version&v1=51.0.2704.81&v2=52.0.2743.98

what on earth happened to "gpu hang"?
Ummm, the code might not be retrying in case of gpu process initialization failure, https://cs.chromium.org/chromium/src/content/browser/renderer_host/context_provider_factory_impl_android.cc?sq=package:chromium&l=240

I'll send a patch to fix that.
Spitzer A/B experiments showed a 30% browser stability improvement:

https://uma.googleplex.com/p/chrome/variations/?sid=1f82c17678269c006e23ac967cbbf6da

(dates after 8/9 are not usable since we bumped control to zero and spitzer to 100%).

When I was looking at the actual crash data and limited by experiments there were appreciable differences in the number of reported crashes. 
Oh this is stable. Sorry I got confused between the dev regression and stable improvement.

khushal, not your patch if stable right?
Nope. That patch landed last week.
yfriedman@ were you going to investigate this anymore? All the sources I've looked at confirm this is legit. We did expect improvements here, the shocking points are (1) how much browser stability improved and (2) that GPU/renderer effectively remains the same (early data suggested minor regressions).
Components: Internals>Media
Labels: Proj-Spitzer
Owner: yfried...@chromium.org
Status: Assigned (was: Untriaged)
-> yfriendman per previous comment. Otherwise we can close.

Comment 9 by wnwen@chromium.org, Aug 25 2016

Cc: yfried...@chromium.org
Owner: wnwen@chromium.org
I'll investigate a bit next week as I'm stability sheriffing. If everything looks legit then I'll close this.

Yaron is out for now.
Possibly issue 604295 being fixed, so it went from 7% -> 0%, though DidFailToInitializeOutputSurface went from 17% -> 4%, OnMessageReceived went from 0 -> 3% and RendererDidNavigateAutoSubframe went from 0 -> 12%, so net change is only 24% -> 19%, a 5% difference.

This does not account for browser crash rates going from 230 CPM to 150 CPM, a 35% drop. :/

Nothing else looks significant at least from the crash frontend: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&compProp=product.Version&v1=51.0.2704.81&v2=52.0.2743.98
@wnwen: See c#4. It's pretty clear this is directly related to the launch of Spitzer due to A/B tests. I don't think issue 604295 has any relation. While larger than expected, we did expect browser process stability to improve.
Status: Fixed (was: Assigned)
@c#2 - GPU hang seems to have been split up into the long tail rather than a blanket 15% bucket at the top.

@c#11 - Agreed, the percentage drop also roughly matches. Good work on Spitzer. :)

Will close the bug as we've identified Spitzer going 100% on stable being the root cause.

Sign in to add a comment