New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638297 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Route animation updates directly to property trees

Project Member Reported by jaydasika@chromium.org, Aug 16 2016

Issue description

Instead of going to property trees through layers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a

commit 10d43fc63e60431d6edb5d9a739cfe5ca40ce95a
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Aug 18 04:06:04 2016

cc : Delete LayerImpl::transform

BUG= 638297 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2254543004
Cr-Commit-Position: refs/heads/master@{#412739}

[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl.h
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2016

Labels: merge-merged-2832
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a

commit 10d43fc63e60431d6edb5d9a739cfe5ca40ce95a
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Aug 18 04:06:04 2016

cc : Delete LayerImpl::transform

BUG= 638297 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2254543004
Cr-Commit-Position: refs/heads/master@{#412739}

[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl.h
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
[modify] https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/898b2f178e201a89384927f992735924bdc50ead

commit 898b2f178e201a89384927f992735924bdc50ead
Author: jaydasika <jaydasika@chromium.org>
Date: Sat Aug 20 04:22:09 2016

cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG= 638297 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2253233003
Cr-Commit-Position: refs/heads/master@{#413319}

[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/layers/layer_impl.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/property_tree.cc
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/cc/trees/property_tree.h
[modify] https://crrev.com/898b2f178e201a89384927f992735924bdc50ead/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e1613788e00d4fef7bd76ddcb4ed592b9a347d

commit 09e1613788e00d4fef7bd76ddcb4ed592b9a347d
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Aug 24 21:39:34 2016

cc : Add OnTransformAnimated to transform tree

And use it to update transform animations directly instead of routing
the updates through layers. This CL also changes element_layers_maps to
hold layer_id instead of layer so that we can get the property tree
index for animation update without accessing LayerImpl

BUG= 638297 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2269143003
Cr-Commit-Position: refs/heads/master@{#414153}

[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/layers/layer_impl.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/layers/layer_impl.h
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_host_unittest_picture.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/property_tree.cc
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/cc/trees/property_tree.h
[modify] https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment