New issue
Advanced search Search tips

Issue 638290 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Presubmit complains about missing directory

Project Member Reported by pkotw...@chromium.org, Aug 16 2016

Issue description

In https://codereview.chromium.org/2225683002/ I deleted the only file in chrome/test/android/javatests/src/org/chromium/chrome/test/webapk directory.

The presubmit script complains:

DEBUG:root:GitAffectedFile(chrome/test/android/javatests/src/org/chromium/chrome/test/webapk/TestWebApkServiceImplWrapper.java)
Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/presubmit_support.py", line 1828, in <module>
    sys.exit(main())
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/presubmit_support.py", line 1812, in main
    options.dry_run)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/presubmit_support.py", line 1531, in DoPresubmitChecks
    change.AbsoluteLocalPaths(True), change.RepositoryRoot())
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/presubmit_support.py", line 1096, in ListRelevantPresubmitFiles
    for f in os.listdir(directory):
OSError: [Errno 2] No such file or directory: '/b/build/slave/linux/build/src/chrome/test/android/javatests/src/org/chromium/chrome/test/webapk'
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@
@@@SET_BUILD_PROPERTY@failure_type@"TEST_FAILURE"@@@
@@@SET_BUILD_PROPERTY@failure_hash@"055d88323f13b6174c79a757eaaf150fa3ef7d2a"@@@
 
Cc: pkotw...@chromium.org
Components: Infra>Client>Android
The presubmit complaint looks like a bug. Assigning to infra to determine whether it is in fact a bug.

I do use a weird workflow. I upload CLs using "git cl upload master" instead of "git cl upload"

Comment 2 by estaab@chromium.org, Aug 17 2016

Cc: reillyg@chromium.org
Components: -Infra>Client>Android Infra>SDK
Labels: -Pri-3 Pri-1
Owner: tobiasjs@chromium.org
Status: Assigned (was: Untriaged)
It looks like this could be a regression introduced in depot_tools in https://chromium.googlesource.com/chromium/tools/depot_tools/+/2836bcf8102969bbbe56708d3dd6690bed271d5d%5E%21/#F0

Toby, does this look like it could be due to your change?
Mergedinto: 638343
Status: Duplicate (was: Assigned)
Yeah, it does. 

Sign in to add a comment