New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

image-change-without-resize-shouldnt-layout.html reliably fails on WebKit Mac10.11 (dbg)

Project Member Reported by bsep@chromium.org, Aug 16 2016

Issue description

These two tests are failing reliably after https://codereview.chromium.org/2227423002

fast/images/image-change-without-resize-shouldnt-layout.html
virtual/gpu-rasterization/fast/images/image-change-without-resize-shouldnt-layout.html

Example failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3964

Output (not super helpful I know but that's what it says):
08:09:00.554 5234 [1595/40605] virtual/gpu-rasterization/fast/images/image-change-without-resize-shouldnt-layout.html failed unexpectedly (asserts failed)
08:09:00.554 5266 worker/6 virtual/gpu-rasterization/fast/images/image-change-without-resize-shouldnt-layout.html failed:
08:09:00.554 5266 worker/6  asserts failed

Since it's only failing on Debug I'll disable the test there, but please take a look. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5e1f0930347ac29e6e61ea68bc428e82226020

commit 6c5e1f0930347ac29e6e61ea68bc428e82226020
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Aug 16 18:03:14 2016

Disable image-change-without-resize-shouldnt-layout.html on Mac Debug.

TBR=srirama.m@samsung.com
BUG= 638288 

Review URL: https://codereview.chromium.org/2255513002 .

Cr-Commit-Position: refs/heads/master@{#412291}

[modify] https://crrev.com/6c5e1f0930347ac29e6e61ea68bc428e82226020/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by f...@opera.com, Aug 16 2016

Cc: -le...@chromium.org

Comment 3 by bsep@chromium.org, Aug 16 2016

Labels: OS-Linux
Looks like this is causing trouble on Linux Debug too. I will mark it failing. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8889
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96f441665a24e7d59266d1c1c3aeb154746485cf

commit 96f441665a24e7d59266d1c1c3aeb154746485cf
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Aug 16 21:09:50 2016

Mark fast/images/image-change-without-resize-shouldnt-layout.html failing on Linux Debug.

TBR=srirama.m@samsung.com
BUG= 638288 

Review URL: https://codereview.chromium.org/2249283002 .

Cr-Commit-Position: refs/heads/master@{#412336}

[modify] https://crrev.com/96f441665a24e7d59266d1c1c3aeb154746485cf/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23

commit f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Wed Aug 17 11:54:01 2016

Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG= 638288 ,  637859 

Review-Url: https://codereview.chromium.org/2250323002
Cr-Commit-Position: refs/heads/master@{#412501}

[modify] https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html

Comment 7 by guidou@chromium.org, Aug 17 2016

Those flaky runs don't have the latest patch applied. Will keep monitoring.
@guidou, shall i mark it as fixed now?
I didn't see it on the flakiness dashboard and also in the https://build.chromium.org/p/chromium.webkit/builders/
Can you please confirm

Comment 9 by e...@chromium.org, May 21 2018

Status: Fixed (was: Assigned)
Closing as per comment 8.

Sign in to add a comment