New issue
Advanced search Search tips

Issue 638287 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Sep 2016
Cc:
r...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

CrWinClang is red

Project Member Reported by h...@chromium.org, Aug 16 2016 
E.g. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/11675/steps/compile/logs/stdio

FAILED: obj/base/allocator/unified_allocator_shim/allocator_shim.obj 
C:\b\c\cipd\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/base/allocator/unified_allocator_shim/allocator_shim.obj.rsp /c ../../base/allocator/allocator_shim.cc /Foobj/base/allocator/unified_allocator_shim/allocator_shim.obj /Fd"obj/base/allocator/unified_allocator_shim_cc.pdb"
../../base/allocator/allocator_shim.cc(37,18):  error: unused variable 'g_new_handler_lock' [-Werror,-Wunused-variable]
subtle::Atomic32 g_new_handler_lock = 0;
                 ^
1 error generated.


I'll fix, but I wonder how it got through the commit queue.

Comment 1 by h...@chromium.org, Aug 16 2016 

This the change that broke it: https://codereview.chromium.org/2164653002

And Reid pointed out we do component builds for our CQ bot, and that means not using the allocator shim.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42dafb452ad376705d3579151c159b6f1360c6d1

commit 42dafb452ad376705d3579151c159b6f1360c6d1
Author: hans <hans@chromium.org>
Date: Tue Aug 16 19:11:53 2016

Fix unused variable warning in the Win-Clang build

BUG= 638287 
TBR=primiano

Review-Url: https://codereview.chromium.org/2246863004
Cr-Commit-Position: refs/heads/master@{#412300}

[modify] https://crrev.com/42dafb452ad376705d3579151c159b6f1360c6d1/base/allocator/allocator_shim.cc

Comment 3 by h...@chromium.org, Sep 6 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment