New issue
Advanced search Search tips

Issue 638274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

MemoryCoordinatorClient null pointer crash

Project Member Reported by boliu@chromium.org, Aug 16 2016

Issue description

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/health-plan-clankium-low-end-phone/builds/1991

	signal 11 (SIGSEGV), code 1, fault addr 0x1ba in tid 9575 (Chrome_InProcRe)
	pid: 9539, tid: 9575, name: Chrome_InProcRe  >>> org.chromium.webview_shell <<<
	signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x1ba
	     r0 2e49378c  r1 00000002  r2 2e364b90  r3 00000192
	     r4 a0020728  r5 b761ac38  r6 00000002  r7 a0020718
	     r8 a61955bc  r9 a617bdaa  sl b75d2ae4  fp a5c260b6
	     ip ffffff00  sp a00206e8  lr a4ed2399  pc a4ed23c6
	
	Stack Trace:
	  RELADDR   FUNCTION                                                           
       FILE:LINE
	  011ab3c6 
blink::MemoryCoordinator::onMemoryPressure(blink::WebMemoryPressureLevel) 
/b/build/slave/arm-builder-rel/build/src/third_party/WebKit/Source/platform/MemoryCoordinator.cpp:58
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1007faf2a13282060f7227e8cb6ea96981c6f9eb

commit 1007faf2a13282060f7227e8cb6ea96981c6f9eb
Author: boliu <boliu@chromium.org>
Date: Tue Aug 16 17:30:52 2016

Revert of Add MemoryCoordinatorClient (patchset #3 id:40001 of https://codereview.chromium.org/2230433002/ )

Reason for revert:
Null pointer crash. See  crbug.com/638274 

BUG= 638274 

Original issue's description:
> Add MemoryCoordinatorClient
>
> Also move MemoryCoordinator from core/dom to platform/. This is a preparation for experimenting purge and suspend [1,2].
>
> [1] https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit
> [2] https://codereview.chromium.org/2130683002/
>
> Committed: https://crrev.com/75ce9c3e2c15f2df215184026162dc505df37e4b
> Cr-Commit-Position: refs/heads/master@{#412171}

TBR=esprehn@chromium.org,haraken@chromium.org,tasak@google.com,bashi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2252743002
Cr-Commit-Position: refs/heads/master@{#412276}

[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp
[add] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/core/dom/MemoryCoordinator.h
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/core/fetch/MemoryCache.h
[delete] https://crrev.com/04c2fb7e9ca37c6b2ab596bffcb5a16d7b8ae4d3/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[delete] https://crrev.com/04c2fb7e9ca37c6b2ab596bffcb5a16d7b8ae4d3/third_party/WebKit/Source/platform/MemoryCoordinator.h
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/platform/blink_platform.gypi
[rename] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/web/WebMemoryCoordinator.cpp
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/public/blink_headers.gypi
[rename] https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb/third_party/WebKit/public/web/WebMemoryCoordinator.h

Components: -Blink Blink>MemoryAllocator
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4c7892122d68b2588ae2bd804fc2dc75e15596

commit 5f4c7892122d68b2588ae2bd804fc2dc75e15596
Author: bashi <bashi@chromium.org>
Date: Thu Aug 18 23:06:08 2016

Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from |m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation for experimenting purge and suspend [1,2].

[1] https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG= 638274 

Review-Url: https://codereview.chromium.org/2251853005
Cr-Commit-Position: refs/heads/master@{#412966}

[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/core/core.gypi
[delete] https://crrev.com/fc56b0062cb12b75c7465710e96fe51f86355913/third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp
[delete] https://crrev.com/fc56b0062cb12b75c7465710e96fe51f86355913/third_party/WebKit/Source/core/dom/MemoryCoordinator.h
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/core/fetch/MemoryCache.h
[add] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[add] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/platform/MemoryCoordinator.h
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/platform/blink_platform.gypi
[rename] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/platform/exported/WebMemoryCoordinator.cpp
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/public/blink_headers.gypi
[rename] https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596/third_party/WebKit/public/platform/WebMemoryCoordinator.h

Comment 4 by bashi@chromium.org, Aug 19 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment