New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638261 link

Starred by 12 users
Status: Verified
Owner:
khmel@chromium.org
Closed: Sep 2016
Cc:
khmel@chromium.org
cn...@chromium.org
cywang@chromium.org
█ levarum@chromium.org
█ kuscher@chromium.org
█ yoshiki@chromium.org
█ lpique@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 638656



Sign in to add a comment

arc: Chrome crashes when ARC++ app is closed with [x]

Project Member Reported by khmel@chromium.org, Aug 16 2016 
Inner bug: b/30817552

This comes together with crbug.com/627590, which causes this crash. 627590 is marked as Merge-Approval. So they must come together.

CL: https://codereview.chromium.org/2251493002/

Comment 1 by khmel@chromium.org, Aug 17 2016

Labels: -Pri-2 Pri-1

Comment 3 by yoshiki@chromium.org, Aug 17 2016

Cc: yoshiki@chromium.org
Labels: ARC-ReleaseBlock-Stable M-53

Comment 4 by dimu@chromium.org, Aug 17 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 5 by yoshiki@chromium.org, Aug 18 2016 

Yury, could you merge this patch? I just merged the original patch.

Comment 6 by khmel@chromium.org, Aug 18 2016 

Ok, I will merge this one.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22380ff1bcf6c541f5675c68df63532dc6595ae0

commit 22380ff1bcf6c541f5675c68df63532dc6595ae0
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 01:52:41 2016

Revert of arc: Fix crash on Arc window close. (patchset #1 id:1 of https://codereview.chromium.org/2252283002/ )

Reason for revert:
Wrong resolve

Original issue's description:
> arc: Fix crash on Arc window close.
>
> BUG= 638261 
> BUG=b/30817552
> TEST=Manually on device. No more crashes are observed.
>
> NOTRY=true
> NOPRESUBMIT=true
> TBR=reviewer@chromium.org
>
> Review-Url: https://codereview.chromium.org/2251493002
> Cr-Commit-Position: refs/heads/master@{#412390}
> (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 638261 

Review-Url: https://codereview.chromium.org/2251313002
Cr-Commit-Position: refs/branch-heads/2785@{#652}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/22380ff1bcf6c541f5675c68df63532dc6595ae0/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/22380ff1bcf6c541f5675c68df63532dc6595ae0/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/22380ff1bcf6c541f5675c68df63532dc6595ae0/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/22380ff1bcf6c541f5675c68df63532dc6595ae0/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Comment 10 by khmel@chromium.org, Aug 18 2016

Blocking: 638656
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/800987eb69027f6f34dff840b19c68a83065c6ae

commit 800987eb69027f6f34dff840b19c68a83065c6ae
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 21:46:35 2016

arc: Fix crash on window close (on close race condition).

This handles race condition on window closing.

TEST=Extended browser_tests
TEST=Manually on device
TEST=test_that -b veyron_minnie <IP> cheets_Notification
BUG= 638656 
BUG= 638261 

Review-Url: https://codereview.chromium.org/2256273003
Cr-Commit-Position: refs/heads/master@{#412940}

[modify] https://crrev.com/800987eb69027f6f34dff840b19c68a83065c6ae/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/800987eb69027f6f34dff840b19c68a83065c6ae/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adace59d1600c66657aa4d93b510825efdd44d11

commit adace59d1600c66657aa4d93b510825efdd44d11
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 23:40:17 2016

Revert of arc: Fix crash on Arc window close. (patchset #1 id:1 of https://codereview.chromium.org/2251973003/ )

Reason for revert:
wrong resolve

Original issue's description:
> arc: Fix crash on Arc window close.
>
> BUG= 638261 
> BUG=b/30817552
> TEST=Manually on device. No more crashes are observed.
>
> NOTRY=true
> NOPRESUBMIT=true
> TBR=reviewer@chromium.org
>
> Review-Url: https://codereview.chromium.org/2251493002
> Cr-Commit-Position: refs/heads/master@{#412390}
> (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 638261 

Review-Url: https://codereview.chromium.org/2255383004
Cr-Commit-Position: refs/branch-heads/2785@{#672}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/adace59d1600c66657aa4d93b510825efdd44d11/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/adace59d1600c66657aa4d93b510825efdd44d11/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/adace59d1600c66657aa4d93b510825efdd44d11/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/adace59d1600c66657aa4d93b510825efdd44d11/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab778fe0ba6112332cdac7ff982364e8bba63ed

commit fab778fe0ba6112332cdac7ff982364e8bba63ed
Author: khmel <khmel@chromium.org>
Date: Fri Aug 19 22:58:22 2016

arc: Fix crash on window close (on close race condition).

This handles race condition on window closing.

TEST=Extended browser_tests
TEST=Manually on device
TEST=test_that -b veyron_minnie <IP> cheets_Notification
BUG= 638656 
BUG= 638261 

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2256273003
Cr-Commit-Position: refs/heads/master@{#412940}
(cherry picked from commit 800987eb69027f6f34dff840b19c68a83065c6ae)

Review-Url: https://codereview.chromium.org/2259403002
Cr-Commit-Position: refs/branch-heads/2785@{#689}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/fab778fe0ba6112332cdac7ff982364e8bba63ed/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/fab778fe0ba6112332cdac7ff982364e8bba63ed/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 15 by khmel@chromium.org, Aug 19 2016

Labels: -Hotlist-Merge-Approved Merge-Merged
Status: Fixed (was: Started)

Comment 16 by lhchavez@chromium.org, Aug 22 2016

Cc: khmel@chromium.org levarum@chromium.org lpique@chromium.org
 Issue 639942  has been merged into this issue.

Comment 17 by levarum@chromium.org, Aug 23 2016

Cc: cn...@chromium.org cywang@chromium.org

Comment 18 by rookrishna@chromium.org, Aug 26 2016

Status: Verified (was: Fixed)

Comment 19 by uekawa@chromium.org, Aug 29 2016 

 Issue 639290  has been merged into this issue.

Comment 20 by nya@chromium.org, Aug 30 2016 

Issue 639790 has been merged into this issue.

Comment 21 by cywang@chromium.org, Sep 1 2016

Cc: kuscher@chromium.org
Labels: M-54 Merge-Request-54
Status: Assigned (was: Verified)
merge-request from kuscher (https://buganizer.corp.google.com/issues/31025211).

Comment 22 by dimu@chromium.org, Sep 1 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Commit may have occurred before M54 branch point (8/25/2016), needs manual review.

Comment 23 by keta...@chromium.org, Sep 2 2016 

Do we need this one in M53?

Comment 24 by khmel@chromium.org, Sep 2 2016 

It was already merged to M53 (Comment 13). As I understand we want to make sure this is in M54.

Comment 25 by khmel@chromium.org, Sep 7 2016

Status: Fixed (was: Assigned)

Comment 26 by josa...@google.com, Sep 8 2016

Labels: -Merge-Review-54 Merge-Approved-54
Project Member

Comment 27 by sheriffbot@chromium.org, Sep 11 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 28 by khmel@chromium.org, Sep 12 2016

Labels: -Merge-Approved-54

Comment 29 by rookrishna@chromium.org, Sep 21 2016

Status: Verified (was: Fixed)
8743.35.0 / 54.0.2840.33

Comment 30 by kinaba@chromium.org, Dec 6 2016 

Issue 640513 has been merged into this issue.
►

Sign in to add a comment