New issue
Advanced search Search tips

Issue 638254 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ReportStage no longer specifies full build name

Project Member Reported by akes...@chromium.org, Aug 16 2016

Issue description

Example: https://uberchromegw.corp.google.com/i/chromeos/builders/lumpy-paladin/builds/25867

The "artifacts" link used to specify the canonical name of the artifact (e.g. "lumpy-paladin/R54-8708.0.0-rc4" in this case). This is the name by which you can request hwtests for this build after the fact, so it is pretty useful to have.
 
Cc: dgarr...@chromium.org
+dgarrett@

You touched some code around here lately, I think. Any chance this was collateral damage?

Comment 2 by aut...@google.com, Aug 16 2016

Labels: -current-issue
I did change that. I forget why, probably not for any important reason.
Owner: dgarr...@chromium.org
Status: Assigned (was: Untriaged)
I found the logic that was generating that, based on the upload URL:
  '/'.join(url.split('/')[-3:-1]

I'll see if I can come up with a better way to generate that data.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9df16c30b34e6a226ab6824de16951174b3498c4

commit 9df16c30b34e6a226ab6824de16951174b3498c4
Author: Don Garrett <dgarrett@google.com>
Date: Tue Aug 09 22:47:51 2016

ReportStage: Adjust where artifacts are linked.

We want to generate index.html files and use them for public build
artifacts, so that public builds can be viewed from an unauthenticated
account.

However, we want to link directly to pantheon for private builds so that
developers can more easily navigate to related artifacts.

Rename _UploadArchiveIndex -> _LinkArtifacts, and move link generation
directly into it so that it can adjust the links as needed.

BUG= chromium:633330 ,  chromium:638254 
TEST=run_tests

Change-Id: If04d2c041af4a0888098952bccb3e1b910c1d83a
Reviewed-on: https://chromium-review.googlesource.com/367516
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/9df16c30b34e6a226ab6824de16951174b3498c4/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/9df16c30b34e6a226ab6824de16951174b3498c4/cbuildbot/stages/report_stages.py

Status: Fixed (was: Started)
I believe this is now fixed.

https://uberchromegw.corp.google.com/i/chromeos/builders/beaglebone-paladin/builds/11021
Labels: VerifyIn-54
bulk verified
Status: Verified (was: Fixed)

Sign in to add a comment