New issue
Advanced search Search tips

Issue 638250 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 636884
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

86.2%-198% regression in smoothness.tough_filters_cases at 412123:412167

Project Member Reported by qyears...@chromium.org, Aug 16 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=638250

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjtvJvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgzvr-vgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgztmYsQkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac10
chromium-rel-mac11
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2016

Cc: erikc...@chromium.org
Owner: erikc...@chromium.org

=== Auto-CCing suspected CL author erikchen@chromium.org ===

Hi erikchen@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2238113002/ )
Author  : erikchen
Commit description:
  
Reason for revert:
Landing again, since main performance regressions have been dealt with.

https://bugs.chromium.org/p/chromium/issues/detail?id=636884

Original issue's description:
> Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ )
>
> Reason for revert:
> Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching.
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=636884
>
> Original issue's description:
> > Enable promotion of RenderPassDrawQuads to CALayers.
> >
> > BUG= 581526 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> >
> > Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c
> > Cr-Commit-Position: refs/heads/master@{#411055}
>
> TBR=ccameron@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 581526 
>
> Committed: https://crrev.com/314269eae868551bb560428fce916863e4d60cb4
> Cr-Commit-Position: refs/heads/master@{#411505}

TBR=ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 581526 

Review-Url: https://codereview.chromium.org/2249923003
Cr-Commit-Position: refs/heads/master@{#412144}
Commit  : 777aa9fb4a33a0ae71ed5363225d52ed807a5ff0
Date    : Tue Aug 16 02:36:57 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@412143  20.666   0.225163  5  good
chromium@412144  59.8543  2.60778   5  bad    <--
chromium@412145  60.2462  1.57516   5  bad
chromium@412147  60.985   0.800447  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 638250

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_filters_cases
Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100
Relative Change: 195.10%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2306
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004159004776531248


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5051195773681664

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 636884
Status: Duplicate (was: Assigned)

Sign in to add a comment