New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638247 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Figure out whether we should generate WebAPKs if web manifest does not contain any icon URLs

Project Member Reported by pkotw...@chromium.org, Aug 16 2016

Issue description

Figure out whether we should generate WebAPKs if web manifest does not contain any icon URLs

 
Cc: hanxi@chromium.org yfried...@chromium.org pkotw...@chromium.org hartma...@chromium.org scottkir...@chromium.org
Owner: sbirch@chromium.org
Status: Assigned (was: Untriaged)
When a user selects "Add to Homescreen" from the app menu, we generate a web app even if the Web Manifest does not contain any "icons". We fall back to using the page favicon.

We have been operating with the assumption that we will generate WebAPKs for web manifests with no icons and fall back to the page favicon as well.

Dominick mentioned (offline and via code review) that:
- We currently require the Web Manifest to have non-empty icon URLs in order to display the add-to-homescreen banner
- Falling back to the page favicon for WebAPKs would add a bit of complexity

Sam, what is the desired long term behavior? Should we generate WebAPKs for Web Manifests with no icon URL. According to Glenn's spreadsheet, 96% of Web Manifests also contain an icon
Dominick is suggesting not generating WebAPKs for Web Manifests with no icon URL for the dev preview (regardless of what the long term decision is). I am fine with this decision
Given
"- We currently require the Web Manifest to have non-empty icon URLs in order to display the add-to-homescreen banner"

I agree with not creating a WebAPK in this case. Add to homescreen menu resulting in a WebAPK should only override engagement checks for the banner - not offer differing triggering logic.

Comment 4 by sbirch@chromium.org, Aug 16 2016

Agreed with Yaron -- no reason to introduce a difference here. Given that the vast majority of sites have icons (probably even more as a % of PWAs) I don't think it's a big issue.
Status: Fixed (was: Assigned)
Decision made, marking as fixed

Sign in to add a comment