New issue
Advanced search Search tips

Issue 638239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add promise to pointerevent automations

Project Member Reported by nzolghadr@chromium.org, Aug 16 2016

Issue description

Since gpu benchmarking sends the actions asynchronously we need to have a way of waiting for them to be done before doing the next action.

Adding promise to the test would help here.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/698aa9d870b2cd6f52e75efd2989985f96d1d5db

commit 698aa9d870b2cd6f52e75efd2989985f96d1d5db
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed Aug 17 19:26:06 2016

Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG= 638239 

Review-Url: https://codereview.chromium.org/2252683002
Cr-Commit-Position: refs/heads/master@{#412611}

[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-auto-css_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-automation.js
[modify] https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js

Status: Fixed (was: Started)

Sign in to add a comment