New issue
Advanced search Search tips

Issue 638191 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup code related to continuous spell checking

Project Member Reported by xiaoche...@chromium.org, Aug 16 2016

Issue description

There is no "non-continuous spell checking" in the current code base, and "continuous spell checking" simply refers to "spell checking".

We should cleanup the code base by renaming things like "isContinuousSpellCheckingEnabled" to "isSpellCheckingEnabled".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc40169f814a34448532c8ead3241275ab785d35

commit fc40169f814a34448532c8ead3241275ab785d35
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 05:12:08 2016

Rename "ContinuousSpellChecking" to "SpellChecking" in Blink

The concept "continuous spell checking" is meaningless as there is no
non-continuous spell checking. Hence, this patch performs the following
renamings to make them more accurate:
- "isContinuousSpellCheckingEnabled" to "isSpellCheckingEnabled"
- "enableContinuousSpellChecking" to "enableSpellChecking"
- "toggleContinuousSpellChecking" to "toggleSpellChecingEnabled"

BUG= 638191 

Review-Url: https://codereview.chromium.org/2251693003
Cr-Commit-Position: refs/heads/master@{#412451}

[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/components/spellcheck/renderer/spellcheck_provider.cc
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/accessibility/misspellings.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-disable-enable.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-multiframe.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/editing/spelling/spelling-huge-text.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/LayoutTests/fast/dom/Text/normalize-crash-in-spell-checker.html
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/page/SpellCheckerClient.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35/third_party/WebKit/public/web/WebLocalFrame.h

Cc: timvolod...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d77295eb003a0e0f9233666c65d18ef87681c94

commit 9d77295eb003a0e0f9233666c65d18ef87681c94
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Aug 19 03:22:19 2016

Rename spellcheck::pref::kEnableContinuousSpellcheck to ...::kEnableSpellcheck

This patch does the above renaming because "continuous spell checking"
is a name that does not make too much sense, and the renamed flag is
simply indicating whether spell checking is enabled.

This patch does exactly 's/kEnableContinuousSpellcheck/kEnableSpellCheck/g'.

This is a followup patch of http://crrev.com/2251693003 that does the
same renaming in Blink.

BUG= 638191 

Review-Url: https://codereview.chromium.org/2254533003
Cr-Commit-Position: refs/heads/master@{#413043}

[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/spellchecker/spellcheck_factory.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/chrome/browser/spellchecker/spelling_service_client_unittest.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/components/spellcheck/browser/pref_names.cc
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/components/spellcheck/browser/pref_names.h
[modify] https://crrev.com/9d77295eb003a0e0f9233666c65d18ef87681c94/components/spellcheck/browser/spelling_service_client.cc

Status: Fixed (was: Assigned)
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment