New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638184 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

offsetLeft wrong for inline inside positioned inline

Reported by msten...@opera.com, Aug 16 2016

Issue description

offsetLeft includes the width of text preceding the positioned offsetParent inline.

 
tc.html
384 bytes View Download
Status: Available (was: Untriaged)
Edge passes
Firefox 51.0a1 (2016-08-12) passes

Comment 2 by lunalu@chromium.org, Aug 31 2016

Owner: lunalu@chromium.org

Comment 3 by lunalu@chromium.org, Aug 31 2016

Owner: ----

Comment 4 by ka...@opera.com, Oct 12 2016

Owner: ka...@opera.com
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f903f01899c880f15af678b6e44404a7d9b1735f

commit f903f01899c880f15af678b6e44404a7d9b1735f
Author: karlo <karlo@opera.com>
Date: Thu Nov 03 14:06:40 2016

Make offsetTop/Left handle a relative positioned inline offsetParent correctly.

offsetTop and offsetLeft happily ignored the fact that offsetParent could
be a relative positioned inline.

I used the opportunity to change some variable names in
LayoutBoxModelObject::adjustedPositionRelativeTo() in order to hopefully
make it clearer what's going on.

BUG= 638184 

Review-Url: https://codereview.chromium.org/2414683002
Cr-Commit-Position: refs/heads/master@{#429571}

[add] https://crrev.com/f903f01899c880f15af678b6e44404a7d9b1735f/third_party/WebKit/LayoutTests/fast/inline/inline-offsetLeft-relpos-expected.txt
[add] https://crrev.com/f903f01899c880f15af678b6e44404a7d9b1735f/third_party/WebKit/LayoutTests/fast/inline/inline-offsetLeft-relpos.html
[modify] https://crrev.com/f903f01899c880f15af678b6e44404a7d9b1735f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/f903f01899c880f15af678b6e44404a7d9b1735f/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/f903f01899c880f15af678b6e44404a7d9b1735f/third_party/WebKit/Source/core/layout/LayoutInline.h

Comment 7 by ka...@opera.com, Nov 3 2016

Status: Fixed (was: Started)

Sign in to add a comment