New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638155 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 593267
issue 632361



Sign in to add a comment

Change LinkPreload from a resource type to a separate flag

Project Member Reported by droger@chromium.org, Aug 16 2016

Issue description

We need to pipe a separate indication that the resource in question is a
link preload (and kill the LinkPreload resource type while we're at it).

Currently the `forPreload` flag is confusing link preload and preloadScanner
based preloads. We need to split that up.

From https://codereview.chromium.org/2219663005/#msg9.

This is needed in particular to be able to tag any resource with the LOAD_PREFETCH network flag, regardless of its resource type.
 

Comment 1 by droger@chromium.org, Aug 16 2016

Blocking: 632361

Comment 2 by droger@chromium.org, Aug 16 2016

Blocking: 593267

Comment 3 by pasko@chromium.org, Aug 16 2016

Cc: -y...@yoav.ws pasko@chromium.org y...@yoav.wsm

Comment 4 by pasko@chromium.org, Aug 16 2016

Cc: -y...@yoav.wsm y...@yoav.ws

Comment 5 by droger@chromium.org, Aug 16 2016

As I read the code more carefully, it seems that LinkPrefetch is controlling the LOAD_PREFETCH flag, not LinkPreload.

Maybe both should be removed? 

Comment 6 by droger@chromium.org, Aug 16 2016

I started a CL:
https://codereview.chromium.org/2249913003/

This is not ready for review at all: it merely compiles, but I don't know if it works yet.

Comment 7 by y...@yoav.ws, Aug 16 2016

LinkPrefetch is the resource type for all <link rel=prefetch> resources. In that case, it makes sense to have a separate resource type, as there's a lot of behavior and priorities that are related to these fetches. 

Comment 8 by droger@chromium.org, Aug 18 2016

Status: WontFix (was: Assigned)
Closing this bug, since it's conflating several issues (LinkPrefetch and LinkPreload) and is prone to confusion.

Sign in to add a comment