New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638146 link

Starred by 1 user
Status: Fixed
Owner:
ftang@chromium.org
Closed: Aug 2016
Cc:
█ pendar@google.com
nyerramilli@chromium.org
█ groby@chromium.org
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Space between Page Language Dropdown and 'Cross' icon is not proper on Translate bubble.

Reported by dmascare...@etouch.net, Aug 16 2016 
Version:54.0.2830.0 (Official Build) b6678f521d7dd83c84e701140739cc3b47afe5d8-refs/heads/master@{#412124}(32/64-bit)
OS:Mac (10.10.4,10.11.4)

Pre-condition: Enable 'New Translate UX' flag.

What steps will reproduce the problem?
1. Launch chrome and navigate to any webpage or https://chrome.google.com/webstore/category/apps?hl=en
2. Right click on page such that context menu gets open and select 'Translate to English' option (Bubble will appears).
3. Click on 'Options' link and observe.

Actual:Space between Page Language Dropdown and 'Cross' icon is not proper
Expected: Spacing should be proper.

This is regression issue, broken in 'M 54' and will soon update the bisect info.

Note: Issue is not seen on Windows and Linux Os.

Comment 1 by dmascare...@etouch.net, Aug 16 2016

Labels: hasbisect
Owner: ftang@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/893311650c65a738a6b9d1921a9d485772c37a72..ed1aa9406798330bec80f9195ed19dba752ba569?pretty=fuller&n=1000

Suspecting: r411887 

Good build:54.0.2828.0
Bad build:54.0.2829.0

Comment 2 by ranjitkan@chromium.org, Aug 16 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by ftang@chromium.org, Aug 16 2016 

Reporter - Please define "proper".

Comment 4 by ftang@chromium.org, Aug 16 2016 

the real look does not have the light blue circle around the x.

Comment 5 by ftang@chromium.org, Aug 16 2016

Cc: groby@chromium.org pendar@google.com
I could increase the vertical space in the advanced Translate Bubble view to push down the "Page Language" and the top drop down menu more. However, I won't be able to fix it correctly unless there is a well-defined "proper" vertical space agreed between QA and UI/UX first.

Comment 6 by dmascare...@etouch.net, Aug 17 2016 

With response to comment #3:

Please find the attached expected screenshot of Windows OS i.e. Space between dropdown and cross icon is seen properly on Windows.

Comment 7 by ftang@chromium.org, Aug 17 2016 

If I change the Mac Bubble like this, would you say the space is "proper"? Or do you think it is still not proper?
Screen Shot 2016-08-16 at 10.45.40 PM.png
42.3 KB View Download

Comment 8 by pendar@google.com, Aug 17 2016 

Ideally this should be answered by Chrome VisD folks, but the new spacing in the screenshots look pretty good to me.

Comment 9 by ftang@chromium.org, Aug 17 2016 

 dmascarenhas@etouch.net - could you confirm the spacing in the latest attached png looks "Proper"? If so, I will send out for code review for the fix.

Comment 10 by dmascare...@etouch.net, Aug 18 2016 

With response to comment #9:

Latest attached screenshots look proper.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6b66b8b689b6f2b5ba47a06e6ef6c453434b1c0

commit e6b66b8b689b6f2b5ba47a06e6ef6c453434b1c0
Author: ftang <ftang@chromium.org>
Date: Thu Aug 18 15:40:51 2016

add padding for icon on advance view

BUG= 638146 

Review-Url: https://codereview.chromium.org/2256883004
Cr-Commit-Position: refs/heads/master@{#412841}

[modify] https://crrev.com/e6b66b8b689b6f2b5ba47a06e6ef6c453434b1c0/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

Comment 12 by ftang@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)

Comment 13 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Translate UI>Browser>Language>Translate
►

Sign in to add a comment