New issue
Advanced search Search tips

Issue 638144 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

ASSERTION FAILED: object.isBox() (was Crash in WTF::StringImpl::hash)

Project Member Reported by ClusterFuzz, Aug 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6500767995527168

Fuzzer: inferno_twister
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x0000000b
Crash State:
  WTF::StringImpl::hash
  WTF::HashTable<WTF::String,WTF::KeyValuePair<WTF::String,blink::Member<blink::Nt
  blink::SVGElement::cssPropertyIdForSVGAttributeName
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_content_shell&range=411875:411885

Minimized Testcase (2.53 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94fiuEz6kWPrzZxIDXsB8iFZJmsrZ19vj9NdqgPtj-OO8KYIHNhoCv3YqZC_uoB2zIlx5lB0EOWOCS0MVS2NuEDW3-dlBVrvDzFBsd_3iwVYB9oZesXbodQi1UtY9atPfuChTV__XvEncTqG-D_-o0K4P4ggQ?testcase_id=6500767995527168

Additional requirements: Requires HTTP

Issue manually filed by: ajha

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by ajha@chromium.org, Aug 16 2016

Cc: ajha@chromium.org
Components: Tools>Test>FindIt>NoResult
Labels: M-54 Te-Logged
Owner: esprehn@chromium.org
Status: Assigned (was: Untriaged)
Findit result:
===============
Suspected CLs	Findit could not find any suspected CLs.

Suspected Project: chromium

From the regression range of the above report.

Assigning to esprehn@ for 'StringImpl.h' related change.

esprehn@: Could you please help in investigating this crash.

Thank you! 
Components: Blink>SVG
The call stack here doesn't make any sense, it does:

PaintInvalidationState::updateForNormalChildren -> LayoutBox::clippingRect -> SVGElement::collectStyleForPresentationAttribute.

I'm looking at that patch and it shouldn't change behavior which makes me wonder if this is an older crash that I just changed the stack of?
Components: -Blink>SVG Blink>Paint
Owner: ----
Status: Available (was: Assigned)
This is actually a bad cast in the paint code, it crashes in blink::toLayoutBox in a debug build.

[471:471:0816/083436:598460889325:INFO:CONSOLE(0)] "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated and will be removed. Please use CSS animations or Web animations instead.", source:  (0)
ASSERTION FAILED: object.isBox()
../../third_party/WebKit/Source/core/layout/LayoutBox.h(1130) : const blink::LayoutBox &blink::toLayoutBox(const blink::LayoutObject &)
1   0x7efd87e756e6
2   0x7efd87fdcdfb blink::PaintInvalidationState::updateForNormalChildren()
3   0x7efd87fdca65 blink::PaintInvalidationState::updateForChildren(blink::PaintInvalidationReason)
4   0x7efd880c1c04 blink::LayoutObject::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
5   0x7efd880c1caa blink::LayoutObject::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
6   0x7efd8802ef77 blink::LayoutBox::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
7   0x7efd88047874 blink::LayoutBoxModelObject::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
8   0x7efd880c1caa blink::LayoutObject::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
9   0x7efd8802ef77 blink::LayoutBox::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
10  0x7efd88047874 blink::LayoutBoxModelObject::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
11  0x7efd880c1caa blink::LayoutObject::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
12  0x7efd8802ef77 blink::LayoutBox::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
13  0x7efd88047874 blink::LayoutBoxModelObject::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
14  0x7efd880c1caa blink::LayoutObject::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
15  0x7efd8802ef77 blink::LayoutBox::invalidatePaintOfSubtreesIfNeeded(blink::PaintInvalidationState const&)
16  0x7efd88047874 blink::LayoutBoxModelObject::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
17  0x7efd87bfb735
18  0x7efd87beadae blink::FrameView::invalidateTreeIfNeeded(blink::PaintInvalidationState const&)
19  0x7efd87bf3b0c blink::FrameView::invalidateTreeIfNeededRecursiveInternal()
20  0x7efd87bf221b blink::FrameView::invalidateTreeIfNeededRecursive()
21  0x7efd87bf135b blink::FrameView::updateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState)
22  0x7efd87bf0d22 blink::FrameView::updateAllLifecyclePhases()
23  0x7efd87e2256a blink::PageAnimator::updateAllLifecyclePhases(blink::LocalFrame&)
24  0x7efd8aaa2cb5
25  0x7efd8ab8c0c8 blink::WebViewImpl::updateAllLifecyclePhases()
26  0x7efd93226aca content::RenderWidget::UpdateVisualState()
27  0x7efd9307a80a content::RenderWidgetCompositor::UpdateLayerTreeHost()
28  0x7efd8e1d023d cc::LayerTreeHost::RequestMainFrameUpdate()
29  0x7efd8e2955cb cc::ProxyMain::BeginMainFrame(std::unique_ptr<cc::BeginMainFrameAndCommitState, std::default_delete<cc::BeginMainFrameAndCommitState> >)
30  0x7efd8e2c2cc8
31  0x7efd8e2c2b9f

Summary: ASSERTION FAILED: object.isBox() (was Crash in WTF::StringImpl::hash) (was: Crash in WTF::StringImpl::hash)

Comment 5 by f...@opera.com, Aug 16 2016

PaintInvalidationState::updateForNormalChildren looks a bit fishy (wrt isSVG) at a quick read - I take it the TC has a <foreignObject> or a <text> w/ a 'clip related' property?

Comment 6 by f...@opera.com, Aug 16 2016

Cc: wangxianzhu@chromium.org

Comment 7 by f...@opera.com, Aug 16 2016

s/has a/has something else than a/
Cc: -wangxianzhu@chromium.org chrishtr@chromium.org
Components: -Blink>Paint Blink>Paint>Invalidation
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
This is caused by recent change above the toLayoutBox() call from hasOverflowClip to hasClipRelatedProperty() (https://chromium.googlesource.com/chromium/src/+/3d30a67e378ec3fcaac5809305584bbabca88e18).

I'm taking it as chrishtr@ is on vacation.
Status: Fixed (was: Assigned)
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment