New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638108 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

devirt-want: LayoutObject::isFlexibleBox

Project Member Reported by krasin@chromium.org, Aug 16 2016

Issue description

isFlexibleBox seems like a perfect example for devirtualization as it has two overrides:

LayoutObject:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/LayoutObject.h?cl=GROK&gsn=isChildAllowed&rcl=1471276009&l=1214

virtual bool isFlexibleBox() const { return false; }

and

LayoutFlexibleBox:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h?cl=GROK&gsn=isChildAllowed&rcl=1471276009&l=49

bool isFlexibleBox() const final { return true; }

For some reason this method is not in the list of devirtualized methods:
https://storage.googleapis.com/cfi-stats/2016-08-15/devirt-methods.html

This looks like a bug to be fixed.
 
Status: Assigned (was: Untriaged)

Sign in to add a comment