New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638087 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to download PDF after clicking on download button.

Reported by mni...@etouch.net, Aug 16 2016 
Version: 54.0.2829.0 aa5a827fabbe04bcabecf997edc18ffe72ced592-refs/heads/master@{#411902} (64-bit)
OS: Mac OS X(10.11.4,10.11.5)
URL : http://www.orimi.com/pdf-test.pdf

What steps will reproduce the problem?
1) Launch chrome , navigate to above url.
2) Now click on download button on top RHS and observe

Actual : Unable to download PDF after clicking on download button
Expected : Should be able to download PDF

This is a regression issue broken in 'M-54' and will soon update other infoe
Actual_video.mov
1.1 MB Download

Comment 1 by mni...@etouch.net, Aug 16 2016

Labels: hasbisect OS-Linux OS-Windows
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in 'M-54' and below is the manual regression and Narrow bisect info:
Good build : 54.0.2828.0 
Bad build : 54.0.2829.0

Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/ba7296e9230d751eeddd23b42be7f6f7cf487a60..6cba7292edf5364ac5d75244abd5e825183161c2?pretty=fuller&n=100

Suspecting : r411847 from Narrow bisect 

@thestig : Could you please help to reassign if your change is not the cause for this change.
Expected_video.mov
1.4 MB Download

Comment 2 by thestig@chromium.org, Aug 16 2016 

Actually, it's r411848 but that's still me.

Comment 3 by ranjitkan@chromium.org, Aug 16 2016

Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c1ffdccf7a7244e4b035532147757e80f1bd66

commit e6c1ffdccf7a7244e4b035532147757e80f1bd66
Author: thestig <thestig@chromium.org>
Date: Tue Aug 16 15:41:57 2016

Fix the PDF download button.

r411848 did not update the message receiving from RVH to RFH, even though
the sender changed from RV to RF.

BUG= 638087 

Review-Url: https://codereview.chromium.org/2246373003
Cr-Commit-Position: refs/heads/master@{#412251}

[modify] https://crrev.com/e6c1ffdccf7a7244e4b035532147757e80f1bd66/components/pdf/browser/pdf_web_contents_helper.cc
[modify] https://crrev.com/e6c1ffdccf7a7244e4b035532147757e80f1bd66/components/pdf/browser/pdf_web_contents_helper.h

Comment 5 by thestig@chromium.org, Aug 16 2016

Status: Fixed (was: Assigned)
Will follow up with a test case.

Comment 6 by ranjitkan@chromium.org, Aug 19 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2832.2
Rechecked this issue on chrome version 54.0.2832.2 on Windows 7, MAC 10.11.6, Ubuntu 14.04. Fix is working as intended. Adding TE-verified labels.

Thanks.!
►

Sign in to add a comment