New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 637950



Sign in to add a comment

[Sync] Device info should have its own subfolder inside //components/sync

Project Member Reported by maxbogue@chromium.org, Aug 16 2016

Issue description

The device info code is currently inside //components/sync/driver, but it is conceptually independent enough to have its own subfolder of sync that is a sibling DEPS-wise to driver/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32

commit f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Aug 16 19:13:20 2016

[Sync] Create //components/sync/device_info.

This CL creates a new sync subfolder for all the device_info code. It is
still co-dependent on driver/, but since conceptually device_info is its
own data type it should get its own folder.

BUG= 638086 
TBR=jam

Review-Url: https://codereview.chromium.org/2250033002
Cr-Commit-Position: refs/heads/master@{#412301}

[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/browser_sync/browser/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/browser_sync/browser/profile_sync_service.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/browser_sync/browser/profile_sync_service_mock.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/history/core/browser/history_delete_directives_data_type_controller.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/BUILD.gn
[add] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/DEPS
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_count_metrics_provider.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_count_metrics_provider.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_count_metrics_provider_unittest.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_data_type_controller.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_data_type_controller.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_data_type_controller_unittest.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_service.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_service.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_service_unittest.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_sync_service.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_sync_service.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_sync_service_unittest.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_tracker.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_util.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_util.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/device_info_util_unittest.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider_impl.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider_impl.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider_mock.cc
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider_mock.h
[rename] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/device_info/local_device_info_provider_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/DEPS
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/shared_change_processor_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync/driver/sync_api_component_factory_mock.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync_sessions/session_data_type_controller.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync_sessions/session_data_type_controller_unittest.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync_sessions/sessions_sync_manager.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/components/sync_sessions/sessions_sync_manager.h
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc
[modify] https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc

Status: Fixed (was: Assigned)
Labels: Sync-Code-Health
Labels: -Sync-Code-Health Hotlist-CodeHealth

Sign in to add a comment