New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638059 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Failure cases not handled properly in IpTablesTest

Project Member Reported by wyszynski@google.com, Aug 16 2016

Issue description

Version: 54.0.2826.0
OS: Chrome

IpTables::ApplyVpnSetup seems to be written with the intention of not leaking firewall rules in failure cases. However, due to the fact that each of IpTables::ApplyRuleForUserTraffic, IpTables::ApplyMasquerade, and IpTables::ApplyMarkForUserTraffic issue two calls to ExecvNonRoot and fail if at least one of them returns a non-zero exit code, it is possible for ApplyVpnSetup to leak a firewall rule if only one of the shell commands issued by on of these function fails but the other succeeds. This is evident from the fact that usernames are not tracked unless their corresponding calls to ApplyMarkForUserTraffic return true. 


 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 16 2016

Labels: Hotlist-Google
Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
This owner is not able to receive e-mails, please re-triage.
Labels: Enterprise-Triaged

Sign in to add a comment