New issue
Advanced search Search tips

Issue 638033 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.6% regression in smoothness.tough_path_rendering_cases at 411559:411576

Project Member Reported by benjhayden@chromium.org, Aug 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=638033

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjqHNrQkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2016

Mergedinto: 637363
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland "Raster display item lists via a visual rect RTree."
Author  : wkorman
Commit description:
  
Rather than caching and playing back an entire SkPicture
when rastering a display item list for a particular
playback rect, instead retain display items and query
them via an RTree of their visual rects to find and
raster only what's needed.

Display item lists no longer support the notion of a
bounding "layer rect" with mutable origin.

DisplayItemListSettings proto is obsolete after this
change as it's comprised solely of one field to allow
switching whether to use the aforementioned now-deleted
cached SkPicture code path. It will be deleted in a
subsequent patch.

Last reverted change: http://crrev.com/2217263003

BUG= 529938 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=chrishtr,vmpstr

Review-Url: https://codereview.chromium.org/2225563002
Cr-Commit-Position: refs/heads/master@{#411560}
Commit  : 971a9c9725e293bd89b7cb1475acdc502065e6b3
Date    : Fri Aug 12 05:55:13 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@411558  18.997   0.0793977  5  good
chromium@411559  19.0601  0.139856   5  good
chromium@411560  19.4321  0.110672   5  bad    <--
chromium@411561  19.442   0.0947277  5  bad
chromium@411563  19.413   0.0973887  5  bad
chromium@411567  19.4224  0.0931152  5  bad
chromium@411576  19.3805  0.0592971  5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 638033

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_path_rendering_cases
Test Metric: frame_times/frame_times
Relative Change: 2.02%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1577
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004218625454513280


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5807624876982272

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment