New issue
Advanced search Search tips

Issue 638020 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.7% regression in blink_perf.bindings at 411741:411786

Project Member Reported by benjhayden@chromium.org, Aug 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=638020

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjvWytgoM


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2016

Cc: wfh@chromium.org
Owner: wfh@chromium.org

=== Auto-CCing suspected CL author wfh@chromium.org ===

Hi wfh@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add Win32k lockdown for PPAPI processes to finch testing parameters.
Author  : wfh
Commit description:
  
BUG=579223

Review-Url: https://codereview.chromium.org/2243953002
Cr-Commit-Position: refs/heads/master@{#411761}
Commit  : 8f7a478791623f4af72be16da30817f6ff753175
Date    : Fri Aug 12 20:50:32 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@411740  231.47   7.53557  18  good
chromium@411752  232.347  5.74771  27  good
chromium@411758  234.883  5.65979  27  good
chromium@411760  237.153  1.92194  5   good
chromium@411761  226.913  5.1473   8   bad    <--
chromium@411763  230.711  3.93768  18  bad
chromium@411786  231.988  2.83657  12  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 638020

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: node-list-access/node-list-access
Relative Change: 2.00%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6648
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004219296362647920


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5864195367632896

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by wfh@chromium.org, Aug 16 2016

doesn't look like a 15.7% regression, more like... nothing? 231.47 is the same as 231.988 after? Is this a flake?

Comment 5 by wfh@chromium.org, Aug 16 2016

Cc: forshaw@chromium.org
Cc: bsep@chromium.org
The graph looks like the regression was sustained but recovered as of revision 412104.
http://test-results.appspot.com/revision_range?start=412052&end=412104
Maybe this revert caused the graph to recover?
https://codereview.chromium.org/2241183003
bsep, is it possible that this regression was caused and then fixed by your changes?

Comment 7 by bsep@chromium.org, Aug 16 2016

Maybe? I was sheriffing a timeout in FindRequestManagerTest.RemoveFrame/1 and when I did the revert the timeout went away. I guess it's possible that patch messed up performance in other ways, but I have no context for the change.
Owner: paulmeyer@chromium.org
Status: Fixed (was: Assigned)
Then FYI paulmeyer about that possibility. But closing out this bug since the regression has recovered.

Sign in to add a comment