Keren noticed that during storage_qual_retention test, the disk is written before being check, nullifying the purpose of the test:

"""
I have been recording traces of the AVL tests. Looking through the trace of the “Retention” test, I was a little surprised by the results I was getting.
 
From what I understand, the “Retention” test starts out by writing data to storage. It then suspends the platform for 12 hours, wakes it up and verifies the validity of the data, repeatedly for 7 days. In the code I can see that the flag for the loop function is “—verifyonly”. I understood this to mean that the test does not rewrite the data during resume cycles, only verifies the data initially written at the beginning of this test.
 
From the trace I have recorded I can see that at the beginning of each resume cycle the test first writes data, then verifies it. I am attaching the image of the trace. (To get more resume cycles in one trace I changed the suspend duration from 12 hours to 3 minutes)"""
[Picture enclosed]


Looking through the code
The FIO config on the client is ran with VERIFY_ONLY=0. so verify_only=0 in the config file. Looking into debug files from hardware_StorageStress.suspend/hardware_StorageFio.verify*, --verifyonly is not passed as argument to fio.

it is in the requirement:
From a test result directory:
./126-moblab/192.168.231.101/hardware_StorageStress.suspend/hardware_StorageFio
.verify_data_8/

In keyval:
param-requirements=[('8k_async_randwrite', ['--verifyonly'])]

In debug/hardware_StorageFio.verify_data_8.DEBUG
Running 'FILENAME=/dev/mmcblk0p3 FILESIZE=1073741824 VERIFY_ONLY=0 ionice -c 3 fio --output-format=json "/usr/local/autotest/tests/hardware_StorageFio/8k_async_randwrite"'

The error is requirements.options are not FIO options, but option for hardware_StorageFio.py.
Instead of --verifyonly, we should have set 'v'. aka VERIFY_OPTION.

Check in other code if requirements.options are misused.


 

Deleted: image001 (2).jpg 26.2 KB

	image001 (2).jpg 26.2 KB View Download