Chrome Menubar needs to move down in splitview fullscreen, even when not active. |
||||
Issue description""" • SUMMARY: Looks like the top toolbar of a Chrome instance in split view is cut off by the menu bar. Please refer to the attached screenshot for more context. *DIAGNOSIS Chrome's "toolbar" is not an AppKit NSToolbar. It's their own view, which they synchronize to the menu sliding down. They likely need to do this even when they're the inactive window, as in split view """
,
Aug 15 2016
Steps to reproduce: 1. Open a Chrome window, and any other app window which supports full screen. 2. Click and hold the Chrome window's zoom button until a blue overlay appears over half the screen. 3. Drop the window on one side of the screen or the other. 4. Click on the other app's window to half-screen it, too. 5. Click the other app's window to focus it. 6. Move the mouse to the top of the screen to reveal the menu bar.
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f commit cccd612ee508dd2ee75f5d70e46b33bb17a7b88f Author: spqchan <spqchan@chromium.org> Date: Fri Aug 19 01:46:46 2016 [Mac] Reworked FullscreenToolbarController Removed mouse tracking for the menubar since it's unreliable for multiple monitors and SplitScreen. Instead, use the menubar Carbon events to update the toolbar. Removed the animation delays because they were mostly unused. When they actually were used, they would cause bugs and janky movements. Cleaned up dead code and comments BUG= 634981 , 637976 , 637514 Review-Url: https://codereview.chromium.org/2256993002 Cr-Commit-Position: refs/heads/master@{#413018} [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/browser_window_controller_private.h [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/global_error_bubble_controller.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm [modify] https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
,
Aug 19 2016
,
Aug 23 2016
Could you please let us know if the issue is related to dual screen? Also a screencast would be helpful to verify the fix from test team end.
,
Aug 23 2016
Not related to dual screen. Screencasts attached! One shows the broken behavior on my machine in shipping Chrome, the other shows it fixed in Canary. |
||||
►
Sign in to add a comment |
||||
Comment 1 by erikc...@chromium.org
, Aug 15 2016