New issue
Advanced search Search tips

Issue 637975 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

chromite: SyncStageRepoCacheTest.testInitializeRepoNotPopulatedCache fails when running via a symlink

Project Member Reported by vapier@chromium.org, Aug 15 2016

Issue description

since this CL landed, this test has failed on my box:
https://chromium-review.googlesource.com/352241

it's because i have a symlink at ~/chromiumos/ and this test apparently doesn't like that.
$ ls -l ~/chromiumos
lrwxrwxrwx 1 vapier eng 25 May 30  2012 /usr/local/google/home/vapier/chromiumos -> /usr/local/src/chromiumos

if i go to ~/chromiumos/chromite/, the test fails.  if i go to /usr/local/src/chromiumos/chromite/, the test passes.

$ git checkout b24070c2424a849e31067eed81d422d1fd5f8c4d^
$ cbuildbot/stages/sync_stages_unittest SyncStageRepoCacheTest.testInitializeRepoNotPopulatedCache
18:23:56: INFO: Using warm cache "/tmp/chromite.tests36fxu/cache" to populate buildroot "/tmp/chromite.tests36fxu/buildroot"
.
----------------------------------------------------------------------
Ran 1 test in 0.521s

OK

$ git checkout b24070c2424a849e31067eed81d422d1fd5f8c4d
$ cbuildbot/stages/sync_stages_unittest SyncStageRepoCacheTest.testInitializeRepoNotPopulatedCache 
18:23:26: INFO: Using warm cache "/tmp/chromite.testLva2za/cache" to populate buildroot "/tmp/chromite.testLva2za/buildroot"
F
======================================================================
FAIL: [chromite.cbuildbot.stages.sync_stages_unittest] SyncStageRepoCacheTest.testInitializeRepoNotPopulatedCache
Tests basic SyncStage repo cache initialization code.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/src/chromiumos/chromite/lib/timeout_util.py", line 171, in TimeoutWrapper
    func(*args, **kwargs)
  File "/usr/local/src/chromiumos/chromite/cbuildbot/stages/sync_stages_unittest.py", line 226, in testInitializeRepoNotPopulatedCache
    self.validateCache()
  File "/usr/local/src/chromiumos/chromite/cbuildbot/stages/sync_stages_unittest.py", line 195, in validateCache
    self.assertFalse(os.path.exists(broken))
AssertionError: True is not false
 
Owner: vapier@chromium.org
Did you fix this already? I just tried to reproduce it.

Comment 2 by vapier@chromium.org, Apr 13 2017

Owner: dgarr...@chromium.org
it's still broken.  i've been reverting locally and ignoring the test.
cd ~
ln -s sand/quick/ chromiumos
cd ~/chromiumos/chromite

quick$cbuildbot/stages/sync_stages_unittest SyncStageRepoCacheTest.testInitializeRepoNotPopulatedCache
11:55:33: INFO: Using warm cache "/tmp/chromite.testHZDtaM/cache" to populate buildroot "/tmp/chromite.testHZDtaM/buildroot"
.
----------------------------------------------------------------------
Ran 1 test in 0.178s


I don't understand what's different, but looking at the test code now.
Status: Started (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/07d4626c40a501866d7c01954f8cabef7b50f482

commit 07d4626c40a501866d7c01954f8cabef7b50f482
Author: Don Garrett <dgarrett@google.com>
Date: Fri Apr 14 06:54:11 2017

cbuildbot/sync_stages: Remove Repo cache support.

The repo cache concept has long been replaced with the more effective
git cache. So... removing dead code and fixing a problematic test at
the same time.

BUG= chromium:637975 
TEST=run_tests

Change-Id: Ieb84b35c41614abfafd6b2604e5f1226bd60e6ab
Reviewed-on: https://chromium-review.googlesource.com/477271
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/07d4626c40a501866d7c01954f8cabef7b50f482/scripts/cbuildbot.py
[modify] https://crrev.com/07d4626c40a501866d7c01954f8cabef7b50f482/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/07d4626c40a501866d7c01954f8cabef7b50f482/cbuildbot/stages/sync_stages.py

Status: Fixed (was: Started)

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment