New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637970 link

Starred by 2 users
Status: Fixed
Owner:
█ f...@chromium.org
(slow to respond to bugs. if it's i...
Closed: Aug 2016
Cc:
est...@chromium.org
rsleevi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Error reports related to ERR_CERTIFICATE_TRANSPARENCY_REQUIRED are not being sent correctly

Project Member Reported by f...@chromium.org, Aug 15 2016 
Error reports related to ERR_CERTIFICATE_TRANSPARENCY_REQUIRED are being uploaded, but with an empty error status.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36933b3152a7b41c6909d0209687df020e734c9

commit d36933b3152a7b41c6909d0209687df020e734c9
Author: felt <felt@chromium.org>
Date: Tue Aug 16 00:52:00 2016

Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED to error report cert errors

I noticed that ERR_CERTIFICATE_TRANSPARENCY_REQUIRED wasn't being added
to cert reports, so this fixes that.

BUG= 637970 

Review-Url: https://codereview.chromium.org/2232813003
Cr-Commit-Position: refs/heads/master@{#412117}

[modify] https://crrev.com/d36933b3152a7b41c6909d0209687df020e734c9/components/certificate_reporting/cert_logger.proto
[modify] https://crrev.com/d36933b3152a7b41c6909d0209687df020e734c9/components/certificate_reporting/error_report.cc
[modify] https://crrev.com/d36933b3152a7b41c6909d0209687df020e734c9/components/certificate_reporting/error_report_unittest.cc

Comment 2 by f...@chromium.org, Aug 18 2016

Cc: rsleevi@chromium.org est...@chromium.org
Labels: M-53
Status: Fixed (was: Started)

Comment 3 by f...@chromium.org, Aug 18 2016

Labels: Merge-Request-53
Requesting a merge to 53.

Comment 4 by dimu@chromium.org, Aug 18 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e8dcde43672395638fde33a641567aaf65e54b

commit e2e8dcde43672395638fde33a641567aaf65e54b
Author: felt <felt@chromium.org>
Date: Thu Aug 18 21:30:40 2016

Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED to error report cert errors

I noticed that ERR_CERTIFICATE_TRANSPARENCY_REQUIRED wasn't being added
to cert reports, so this fixes that.

BUG= 637970 
TBR=estark@chromium.org

Review-Url: https://codereview.chromium.org/2232813003
Cr-Commit-Position: refs/heads/master@{#412117}
(cherry picked from commit d36933b3152a7b41c6909d0209687df020e734c9)

Review URL: https://codereview.chromium.org/2262513002 .

Cr-Commit-Position: refs/branch-heads/2785@{#669}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e2e8dcde43672395638fde33a641567aaf65e54b/components/certificate_reporting/cert_logger.proto
[modify] https://crrev.com/e2e8dcde43672395638fde33a641567aaf65e54b/components/certificate_reporting/error_report.cc
[modify] https://crrev.com/e2e8dcde43672395638fde33a641567aaf65e54b/components/certificate_reporting/error_report_unittest.cc

Comment 6 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment