New issue
Advanced search Search tips

Issue 637958 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 636420
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13% regression in media.tough_video_cases at 410389:410403

Project Member Reported by liber...@chromium.org, Aug 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=637958

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgtqKjvAsM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2016

Mergedinto: 636420
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Reland #1: "base: Implement GetCurrentThreadPriority." (patchset #2 id:20001 of https://codereview.chromium.org/2215513002/ )
Author  : erikchen
Commit description:
  
Reason for revert:
Still causes startup regressions:

https://bugs.chromium.org/p/chromium/issues/detail?id=635464#c4

Original issue's description:
> Reland #1: "base: Implement GetCurrentThreadPriority."
>
> The Chrome thread priority is saved in the thread dictionary during
> SetCurrentThreadPriority(). This seemed a better approach than using
> thread_policy_get(), since there are 4 Chrome priorities which won't cleanly map
> to thread flavors.
>
> BUG=601270
>
> Committed: https://crrev.com/23d10a36f2e815edd610098a65e5890f279d2183
> Cr-Commit-Position: refs/heads/master@{#410163}

TBR=mark@chromium.org,gab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=601270

Review-Url: https://codereview.chromium.org/2221083002
Cr-Commit-Position: refs/heads/master@{#410390}
Commit  : 23c669b5b4cf228dab6da2cc47293b4650a7b923
Date    : Mon Aug 08 17:55:57 2016


===== TESTED REVISIONS =====
Revision         Mean   Std Dev  N  Good?
chromium@410388  298.4  2.60768  5  good
chromium@410389  296.6  2.19089  5  good
chromium@410390  333.2  4.54973  5  bad    <--
chromium@410392  333.2  9.47101  5  bad
chromium@410396  332.6  4.50555  5  bad
chromium@410403  334.8  7.66159  5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 637958

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests media.tough_video_cases
Test Metric: idle_wakeups_gpu/idle_wakeups_gpu
Relative Change: 12.20%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/831
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004226432369990832


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5845933166690304

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment